From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B494EC433EF for ; Sat, 4 Dec 2021 23:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E19DA6B007D; Sat, 4 Dec 2021 18:53:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA1BE6B0080; Sat, 4 Dec 2021 18:53:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C42A86B0081; Sat, 4 Dec 2021 18:53:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id B04196B007D for ; Sat, 4 Dec 2021 18:53:59 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5ED2E8249980 for ; Sat, 4 Dec 2021 23:53:49 +0000 (UTC) X-FDA: 78881766978.08.F9FA430 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 30BD2B0000AA for ; Sat, 4 Dec 2021 23:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lSqkhUtVhnqxYJBPgDIzRRfQncz5CKDcUotTy5RlLGA=; b=UfzUu3/z/m7s3v2ZPGOuzzWiP3 3Gi9RX7+8QkRaQNOOXU77aZkmc4dTmMdFOd18VYhvZSA9aphHmIYGrF+Rz7A6PF7FuZYvWhaIOBhy oFAWcf/HKVy36QHwogU5eDvDifiIB//rAtG5qWblJxQpZhr58sT63yNLvTKgnVB4DhkTDhNgxe8g6 wr3BMg244QAsGQztOte+qyts43Aw5XWWsJA+G5fD1wrCWv5u/J5ZIq2WXUO1D2pzxiGQnwPppz6Ae 7gNKoA6oAxooiEjWD+Nfy9BLjLHqKr/8O0SDSJU2EdaI5Fb01DvD2UUeJF5YBEG79kz3JD/wrs8D3 +ryIhIFw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mteqM-00F8FV-GZ; Sat, 04 Dec 2021 23:53:26 +0000 Date: Sat, 4 Dec 2021 23:53:26 +0000 From: Matthew Wilcox To: Arnd Bergmann Cc: Alexander Viro , Andrew Morton , Arnd Bergmann , Peter Xu , "Peter Zijlstra (Intel)" , Yu Zhao , Vlastimil Babka , Colin Cross , Alistair Popple , Stephen Rothwell , Michal Hocko , Johannes Weiner , Hugh Dickins , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: split out anon_vma declarations to separate header Message-ID: References: <20211204174417.1025328-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211204174417.1025328-1-arnd@kernel.org> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 30BD2B0000AA X-Stat-Signature: ik439qcebzywey6g1orwbk3gcy5ifhgo Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="UfzUu3/z"; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1638662028-363794 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 04, 2021 at 06:42:17PM +0100, Arnd Bergmann wrote: > This should not really be part of linux/mm_types.h in the first > place, as that header is meant to only contain structure defintions > and need a minimum set of indirect includes itself. While the > header clearly includes more than it should at this point, let's > not make it worse by including string.h as well, which would > pull in the expensive (compile-speed wise) fortify-string logic. > > Move the new functions to a separate header that is only included > where necessary to avoid bloating linux/mm_types.h further. We already have an mm_inline.h. Why do we need a new header file?