From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE77C433EF for ; Sat, 4 Dec 2021 16:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F9546B007E; Sat, 4 Dec 2021 11:58:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A8156B0080; Sat, 4 Dec 2021 11:58:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695736B0081; Sat, 4 Dec 2021 11:58:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 584B56B007E for ; Sat, 4 Dec 2021 11:58:38 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 18DF51809C041 for ; Sat, 4 Dec 2021 16:58:28 +0000 (UTC) X-FDA: 78880720296.17.396CDB6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 8FDA24002087 for ; Sat, 4 Dec 2021 16:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6kcYT10sBhVy5DwYlzCSWp6r/Y2XZkdGIB6Lo+/QhjM=; b=PNH3Xk5FRKeRMwzogxc2VQayoY 2JjJNArtiHYM3dpoisY5VTEIvvZAO27TDW6bl5muTUqUkqY7DOzivjQbIts8NHM9ouUcfCTjIsiFw Ks/I6NC3bDPad1bI9YS6vYsyQ6Vuc/V47lvBmLWe0XlTX4GKLCWWp5qsjiTl4AFpiS/aXtqAVczfV LDQgRVeQH76FDN3NN3feXczyPxXrQmM+27YWKl41EhYbmHMUuOPbmqR0lKSDusgIelK00BK9RwLiK ed1FRrILu24J3WJQ8ybwAvdHxbA90SDO/Dp2uQcuqo0UPDgbHJ653bXcFoY7D68w+O3XJF50ZFCQX XGJIEn0w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtYMZ-00DpuE-7f; Sat, 04 Dec 2021 16:58:15 +0000 Date: Sat, 4 Dec 2021 16:58:15 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: fs/proc/vmcore.c:161:34: sparse: sparse: incorrect type in argument 1 (different address spaces) Message-ID: References: <202111242331.x19Qywph-lkp@intel.com> <5166da50-e2af-139b-9f7f-a1bcabe10775@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5166da50-e2af-139b-9f7f-a1bcabe10775@redhat.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8FDA24002087 X-Stat-Signature: 4oqwwpwzjn77obskz7mimzj4bi677z9a Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PNH3Xk5F; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1638637107-92519 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 05:45:45PM +0100, David Hildenbrand wrote: > On 24.11.21 16:42, kernel test robot wrote: > > sparse warnings: (new ones prefixed by >>) > >>> fs/proc/vmcore.c:161:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __user *p @@ got char *buf @@ > > fs/proc/vmcore.c:161:34: sparse: expected void const [noderef] __user *p > > 159 if (!userbuf) > > 160 memset(buf, 0, nr_bytes); > > > 161 else if (clear_user(buf, nr_bytes)) > > 162 tmp = -EFAULT; > > 163 } else { > > Sparse is wrong as it doesn't see the bigger picture. "int userbuf" > tells us what we're actually dealing with ... Sparse is pointing to a deeper problem here. We should be using an iov_iter throughout vmcore.c, but that's kind of a big project ...