From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3C1C433F5 for ; Fri, 3 Dec 2021 12:41:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8F0F6B0074; Fri, 3 Dec 2021 07:41:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3FF26B0075; Fri, 3 Dec 2021 07:41:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92FCE6B0078; Fri, 3 Dec 2021 07:41:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 8565E6B0074 for ; Fri, 3 Dec 2021 07:41:36 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 340DC85313 for ; Fri, 3 Dec 2021 12:41:26 +0000 (UTC) X-FDA: 78876443772.17.290002F Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf16.hostedemail.com (Postfix) with ESMTP id BD9F5F00008E for ; Fri, 3 Dec 2021 12:41:25 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id t9so5431181wrx.7 for ; Fri, 03 Dec 2021 04:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2DlaYyrMnNAfarN4p4bn7fLOENYHGsS+8GIcDJI44kI=; b=EGQ3aws5Y4/XGWAH1A6EHl4jGKcodEVMaTu6soy7BD9gxMZgtueQRjNgyQltM7OkYu 82ffPIdz00JJ0MN2jQxpmbLVd2134QX2ghdaOLHgE37EfAQttbnZ95sybWO8DAoZTPGy kLkF4dyf9bGIIpn/N6jAvpFyLfMXjRnF0MsVhVHNW87w/tiSpI5iEg18F68Z8K+zi66y UdevS/ahqkO0WBH4R1+4JrhtbdgjTwiLW/ZeCsK83hlq24BIhOoY5TzdmnxqePwOieJ3 rd8BuoOAy+Eb+NycsuNWEHEZgqcSKXxGJiw6GuyTt5ax6o8/MUflJko+mGEGNvYHpAe0 vuEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2DlaYyrMnNAfarN4p4bn7fLOENYHGsS+8GIcDJI44kI=; b=1u+LesnW+EKyO/hDTxcLQK9Zx1mB1r1tkfvaqeQhCc/p7s3Z03NE9SbKkE1WMN7q+P qpvux/iO5DiytiF+Zdc+l0eDRzVYtEvfUmZPayqYljQUnRJgI7pQClw6VR0XmFbEJ/dS xW5ypQztYTbK/DYq70ZT5zegltknZj/ARxoqTHpjEZvWdj00T2XZvjpqCawUEpSOR4eZ zIy25HazrVOgeE42yASSNzuvHcwhItKvWZgIUghFxQuTW8t09lgjIDkR3Sf8tdzqGXgm lpTRLNCmaUBtqFhVgUSud88TnhMP5KCMEmz1fp767Erfm1pzyy9BOhJvHEMbwE00mMgT jVVw== X-Gm-Message-State: AOAM530cFEriJPC94NlvrQ/21pdAypW/TPFg3hFTN6rjcvbmYjXLhRyF ZUHkewg5YdVpnt3CQ1hiWZmqwA== X-Google-Smtp-Source: ABdhPJy/MiBgF2zqfmjd+3J4u1vP4T6FanHvj7EcLrUpNxZ+mISsd53PcHVj/Julw+2v3rUBi0jE+g== X-Received: by 2002:a5d:4889:: with SMTP id g9mr21784593wrq.455.1638535284334; Fri, 03 Dec 2021 04:41:24 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:cb5f:d3e:205e:c7c4]) by smtp.gmail.com with ESMTPSA id z6sm2427482wrm.93.2021.12.03.04.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 04:41:23 -0800 (PST) Date: Fri, 3 Dec 2021 13:41:18 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Vincenzo Frascino , Catalin Marinas , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 27/31] kasan, vmalloc: add vmalloc support to HW_TAGS Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BD9F5F00008E X-Stat-Signature: 1gu5ptsd1rrhxfxc4n76uqziegwc4wmg Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EGQ3aws5; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1638535285-901327 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 11:08PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > This patch adds vmalloc tagging support to HW_TAGS KASAN. > > The key difference between HW_TAGS and the other two KASAN modes > when it comes to vmalloc: HW_TAGS KASAN can only assign tags to > physical memory. The other two modes have shadow memory covering > every mapped virtual memory region. > > This patch makes __kasan_unpoison_vmalloc() for HW_TAGS KASAN: > > - Skip non-VM_ALLOC mappings as HW_TAGS KASAN can only tag a single > mapping of normal physical memory; see the comment in the function. > - Generate a random tag, tag the returned pointer and the allocation. > - Propagate the tag into the page stucts to allow accesses through > page_address(vmalloc_to_page()). > > The rest of vmalloc-related KASAN hooks are not needed: > > - The shadow-related ones are fully skipped. > - __kasan_poison_vmalloc() is kept as a no-op with a comment. > > Poisoning of physical pages that are backing vmalloc() allocations > is skipped via __GFP_SKIP_KASAN_UNPOISON: __kasan_unpoison_vmalloc() > poisons them instead. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino This is missing a Signed-off-by from Vincenzo.