From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF25C433F5 for ; Fri, 3 Dec 2021 12:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16BC86B0072; Fri, 3 Dec 2021 07:38:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 11C466B0074; Fri, 3 Dec 2021 07:38:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED8796B0075; Fri, 3 Dec 2021 07:38:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id DA1656B0072 for ; Fri, 3 Dec 2021 07:38:14 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9A3DB184818C0 for ; Fri, 3 Dec 2021 12:38:04 +0000 (UTC) X-FDA: 78876435288.03.1D85DF0 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf31.hostedemail.com (Postfix) with ESMTP id 4A6861046308 for ; Fri, 3 Dec 2021 12:38:04 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id p18so2220623wmq.5 for ; Fri, 03 Dec 2021 04:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JhF4DJloD8iRgaeJPijyIb6Lv1uWFcqJB9vbZ2tw7/U=; b=Y5fbPakt6NI1S/kY3sqHoChvm/iLe/qHIHAmQYufgFDRp+QJIkkqwxpcPf8cfQJlQ2 iw253ZPMA7SoFhHxb6gzUzhlmbt8xhjZdiMXxbQ1BHS0p7GKYLPaDiGlkdK5/OSqBYJE nOJK24RFSM+wRmcOlDbtYcfe6pIYdDGkxZjwTjpumNiVgJdgXBh/GvUutL5E0xKMbKae KRRVqgEUDkWCRf+7K5mOwxdFbExZtKL7aMDADh0ZXauUdMM3GBcF1JBMb0Hz+gV5hq6E 3G+DwUvOQygOTpAEGOzKF71XncFVfk+E8U3iI00P3WFhI+deVu1Pojn3gRnMfclUpqen U4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JhF4DJloD8iRgaeJPijyIb6Lv1uWFcqJB9vbZ2tw7/U=; b=SSym973/uWhgdeQX4QcbVgIvH/vH4mMs4n+vrobAIVF62f2abD7Sv8valPVJ3SOA2H DbVuWvB8CjleOEnruYIjzVHeQ2eCpWT743JCWOYG46jW/XlR1r5/y4iiFNuJFQNoo+hW xDELiDrhGY7BVLkqWXCA/vSe1yZWYtQxjcXaM2i2kDwjWwZanZbw3fwH2ToNu7eZLfVY tM4Kf+QnCptqWmxJsCNMi0UOqKdtVt6mxeqfJGuoyHJvNk+qquf+WCdnP22TamHuNAxN W4/qdkq7W2a55eav7PXomrouLMrQabTkvjjnSImNu8wFFm1IQqGN646ZFbvpGpMb2vY2 9d9g== X-Gm-Message-State: AOAM533kVu2Nt3f0W+Vs0XoQHUbSMHM2FDESvpBwxGCGWxlbM0kezGXI KOgzx9+zgLaeJxSgcD0MEf/EOQ== X-Google-Smtp-Source: ABdhPJwQBodRT/70beD57Bl0QbM1bN/4aJG4705TNjYW9cEDSDNkfOqHhpxJMeTqa4eESd3rLp0nSw== X-Received: by 2002:a7b:c3c6:: with SMTP id t6mr828526wmj.119.1638535082851; Fri, 03 Dec 2021 04:38:02 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:cb5f:d3e:205e:c7c4]) by smtp.gmail.com with ESMTPSA id q26sm2513762wrc.39.2021.12.03.04.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 04:38:02 -0800 (PST) Date: Fri, 3 Dec 2021 13:37:56 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Vincenzo Frascino , Catalin Marinas , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 23/31] kasan, arm64: allow KASAN_VMALLOC with SW_TAGS Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Queue-Id: 4A6861046308 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y5fbPakt; spf=pass (imf31.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Stat-Signature: 9wzmfwo7ijmacnbnqrp7wopu538unsz4 X-HE-Tag: 1638535084-770034 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 11:07PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > vmalloc support for SW_TAGS KASAN is now complete. > > Allow enabling CONFIG_KASAN_VMALLOC. > > Signed-off-by: Andrey Konovalov This change is small enough that I would have expected the lib/Kconfig.kasan change to appear in "kasan, vmalloc: add vmalloc support to SW_TAGS" because that sounds like it would fully unlock core KASAN support. However, the arm64 change could be in its own patch, since there may be conflicts with arm64 tree or during backports, and only dropping that may be ok. I've been backporting too many patches lately, that I feel that would help. > --- > arch/arm64/Kconfig | 1 + > lib/Kconfig.kasan | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c4207cf9bb17..c05d7a06276f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -206,6 +206,7 @@ config ARM64 > select IRQ_DOMAIN > select IRQ_FORCED_THREADING > select KASAN_VMALLOC if KASAN_GENERIC > + select KASAN_VMALLOC if KASAN_SW_TAGS > select MODULES_USE_ELF_RELA > select NEED_DMA_MAP_STATE > select NEED_SG_DMA_LENGTH > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index cdc842d090db..3f144a87f8a3 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -179,7 +179,7 @@ config KASAN_TAGS_IDENTIFY > > config KASAN_VMALLOC > bool "Back mappings in vmalloc space with real shadow memory" > - depends on KASAN_GENERIC && HAVE_ARCH_KASAN_VMALLOC > + depends on (KASAN_GENERIC || KASAN_SW_TAGS) && HAVE_ARCH_KASAN_VMALLOC > help > By default, the shadow region for vmalloc space is the read-only > zero page. This means that KASAN cannot detect errors involving > -- > 2.25.1 >