From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C867AC433F5 for ; Mon, 29 Nov 2021 22:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 455126B0074; Mon, 29 Nov 2021 17:55:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 401E66B0075; Mon, 29 Nov 2021 17:55:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C97D6B0078; Mon, 29 Nov 2021 17:55:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 1AF056B0074 for ; Mon, 29 Nov 2021 17:55:25 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CE6218DF83 for ; Mon, 29 Nov 2021 22:55:14 +0000 (UTC) X-FDA: 78863475348.22.C732BF7 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf11.hostedemail.com (Postfix) with ESMTP id 7A5F4F000204 for ; Mon, 29 Nov 2021 22:55:14 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id 8so18314556qtx.5 for ; Mon, 29 Nov 2021 14:55:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pEDakQnvUPgfExSNtMrcASRup0dCzLPmxqHNnZuTaEw=; b=A4z9SiPQ+dyP7bL9GYsrM0gran0ySVbgt73OGGiTZ/TnQ/+W29aMM17geC47uBUjOZ +CFHSYIWxAouaicBentUt8vs8Z4f0QSJ7Aoi3LCBLQNEb8dz8uYg11gg56d1i1pCOrPV VxswSvHjgggUWQZBagim7W2xBnfdtjCiB4mtbKe6bfnVkm1V4cErU29aD5KgcQISF6yH kgu0vHoGugZwjI3SEn6XYDec44fuunYyq51O6cL0sCZ9DBPZKi3jdBaArT2rtGasUxX6 uX5SlcvxdzGAxNd99qMFd/XEZNDVzBqLbqWhuaxkVEE+PbJcJVJdVH0VZGe0wqkNKz+2 upEA== X-Gm-Message-State: AOAM532G2nNBx8fVDUdd8aup5B0iIdNULz1CldAe8if0SUkiq6IhiSUu 8CFw1ugls0n9vgFzxk1aZLY= X-Google-Smtp-Source: ABdhPJwhddCBXLud6erDgcxLoWG12ankufJKN/6VQiDHvJFght0g5pwFKu7S2tQHfyQ8XLjcAQQPNA== X-Received: by 2002:ac8:4e56:: with SMTP id e22mr47933221qtw.72.1638226513800; Mon, 29 Nov 2021 14:55:13 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id d9sm9373180qkn.131.2021.11.29.14.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 14:55:13 -0800 (PST) Date: Mon, 29 Nov 2021 17:55:11 -0500 From: Dennis Zhou To: Kefeng Wang Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org, gregkh@linuxfoundation.org, cl@linux.com, catalin.marinas@arm.com, will@kernel.org, tsbogend@alpha.franken.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RFC 0/4] mm: percpu: Cleanup percpu first chunk funciton Message-ID: References: <20211121093557.139034-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211121093557.139034-1-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7A5F4F000204 X-Stat-Signature: bps6chh73p6fdwbgsg5ybjbp7craf9bd Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-HE-Tag: 1638226514-8547 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Sun, Nov 21, 2021 at 05:35:53PM +0800, Kefeng Wang wrote: > When support page mapping percpu first chunk allocator on arm64, we > found there are lots of duplicated codes in percpu embed/page first > chunk allocator. This patchset is aimed to cleanup them and should > no funciton change, only test on arm64. > > Kefeng Wang (4): > mm: percpu: Generalize percpu related config > mm: percpu: Add pcpu_fc_cpu_to_node_fn_t typedef > mm: percpu: Add generic pcpu_fc_alloc/free funciton > mm: percpu: Add generic pcpu_populate_pte() function > > arch/arm64/Kconfig | 20 +---- > arch/ia64/Kconfig | 9 +-- > arch/mips/Kconfig | 10 +-- > arch/mips/mm/init.c | 14 +--- > arch/powerpc/Kconfig | 17 +--- > arch/powerpc/kernel/setup_64.c | 92 +-------------------- > arch/riscv/Kconfig | 10 +-- > arch/sparc/Kconfig | 12 +-- > arch/sparc/kernel/smp_64.c | 105 +----------------------- > arch/x86/Kconfig | 17 +--- > arch/x86/kernel/setup_percpu.c | 66 ++------------- > drivers/base/arch_numa.c | 68 +--------------- > include/linux/percpu.h | 13 +-- > mm/Kconfig | 12 +++ > mm/percpu.c | 143 +++++++++++++++++++++++++-------- > 15 files changed, 165 insertions(+), 443 deletions(-) > > -- > 2.26.2 > I've made a few comments. I think this will be a little bit of a challenge to get through due to it touching so many architectures. For ease, it probably makes sense to run it through mny tree, but we'll need explicit acks as I mentioned. I like getting rid of the pcpu_alloc_bootmem()/pcpu_free_bootmem() functions. However, let's keep the implementation identical to x86. I don't think we should get rid of the populate_pte_fn(). I'm not comfortable changing x86's implementation. Simply offer a NULL, and if NULL use the default. Do you have a tree that intel pulls? I suggest cleaning up the patches and pushing to a remote branch that they pick up. That would have caught the mips typo. Send a PR creating a file in [1] for your branch, github is fine. Basic validation needs to be done before I can pick this up too on more than arm64. [1] https://github.com/intel/lkp-tests/tree/master/repo/linux Thanks, Dennis