From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93F3C433F5 for ; Mon, 29 Nov 2021 02:54:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532636B0071; Sun, 28 Nov 2021 21:54:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3026B0072; Sun, 28 Nov 2021 21:54:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 382846B0073; Sun, 28 Nov 2021 21:54:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 25BD36B0071 for ; Sun, 28 Nov 2021 21:54:48 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E506018259C44 for ; Mon, 29 Nov 2021 02:54:37 +0000 (UTC) X-FDA: 78860449794.08.5D91211 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 31256F00008E for ; Mon, 29 Nov 2021 02:54:32 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id de30so21423696qkb.0 for ; Sun, 28 Nov 2021 18:54:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qbTe+lH71a6p8wzsCbhSxpErG9OzglSEt6YvNDwG21c=; b=PLpM/H0zcb7UVq8TXcxUBZikSJuh6v1dHPLhc8VbFiaStXQtpQyEMKJvAl0C9qolvR 6dFzK6ww64jyVIdhH3F3ytNDva7JswGMVi27C6QInR0VEfP919QePObKnMd9r4BHzz9g QhOtpaAhEar2YxuX6i5nj6T1ARozvM8U6bvp695j2dBALgwKhdrr1eE54gO9QkQ3JXmF ahWq7/5vKnnTYjtdsscJ5j2T5bD49sx7P0IatjIKGWgZgzl1oYx7tt8V9uIigrFcedeV HKh2x/v7HRADoa3GZwIPSADXYcjFHmB7znW2cFDaqtGL/8nqP/n4ppWr1B681/myzdZp w4UQ== X-Gm-Message-State: AOAM531fyrjs5QW4IFIXWYf023sOEETeWxv225eu3BRZNfGIky4Y6+WG UOyp24OCd4L0VpeIfxt4yZQ= X-Google-Smtp-Source: ABdhPJyi7aAcRBTHZ33Xv2m6ARGtjYSUACLIAGWWBFseVcXDEPx4RpqRlD7ZTzSfnjCXSQaXvSA7XQ== X-Received: by 2002:a05:620a:1468:: with SMTP id j8mr36368878qkl.170.1638154476884; Sun, 28 Nov 2021 18:54:36 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id s6sm5164326qko.43.2021.11.28.18.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 18:54:36 -0800 (PST) Date: Sun, 28 Nov 2021 21:54:34 -0500 From: Dennis Zhou To: Kefeng Wang Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org, gregkh@linuxfoundation.org, cl@linux.com, catalin.marinas@arm.com, will@kernel.org, tsbogend@alpha.franken.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH RFC 0/4] mm: percpu: Cleanup percpu first chunk funciton Message-ID: References: <20211121093557.139034-1-wangkefeng.wang@huawei.com> <4fecd1ac-6c0a-f0fa-1ffb-18f3f266809d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fecd1ac-6c0a-f0fa-1ffb-18f3f266809d@huawei.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 31256F00008E X-Stat-Signature: fojzbnuby9ibfi5r91oi9mwa95qb8txd Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-HE-Tag: 1638154472-799293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 29, 2021 at 10:51:18AM +0800, Kefeng Wang wrote: > Hi Dennis and all maintainers, any comments about the changes, many thanks. > > On 2021/11/21 17:35, Kefeng Wang wrote: > > When support page mapping percpu first chunk allocator on arm64, we > > found there are lots of duplicated codes in percpu embed/page first > > chunk allocator. This patchset is aimed to cleanup them and should > > no funciton change, only test on arm64. > > > > Kefeng Wang (4): > > mm: percpu: Generalize percpu related config > > mm: percpu: Add pcpu_fc_cpu_to_node_fn_t typedef > > mm: percpu: Add generic pcpu_fc_alloc/free funciton > > mm: percpu: Add generic pcpu_populate_pte() function > > > > arch/arm64/Kconfig | 20 +---- > > arch/ia64/Kconfig | 9 +-- > > arch/mips/Kconfig | 10 +-- > > arch/mips/mm/init.c | 14 +--- > > arch/powerpc/Kconfig | 17 +--- > > arch/powerpc/kernel/setup_64.c | 92 +-------------------- > > arch/riscv/Kconfig | 10 +-- > > arch/sparc/Kconfig | 12 +-- > > arch/sparc/kernel/smp_64.c | 105 +----------------------- > > arch/x86/Kconfig | 17 +--- > > arch/x86/kernel/setup_percpu.c | 66 ++------------- > > drivers/base/arch_numa.c | 68 +--------------- > > include/linux/percpu.h | 13 +-- > > mm/Kconfig | 12 +++ > > mm/percpu.c | 143 +++++++++++++++++++++++++-------- > > 15 files changed, 165 insertions(+), 443 deletions(-) > > Hi Kefang, I apologize for the delay. It's a holiday week in the US + I had some personal things come up at the beginning of last week. I'll have it reviewed by tomorrow. Thanks, Dennis