From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9082C433EF for ; Sun, 28 Nov 2021 17:54:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3716F6B0075; Sun, 28 Nov 2021 12:54:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F81F6B0078; Sun, 28 Nov 2021 12:54:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14A446B007B; Sun, 28 Nov 2021 12:54:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 03FD26B0075 for ; Sun, 28 Nov 2021 12:54:16 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B9A70852EC for ; Sun, 28 Nov 2021 17:54:05 +0000 (UTC) X-FDA: 78859087608.17.739AF77 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf23.hostedemail.com (Postfix) with ESMTP id 8D52690000A5 for ; Sun, 28 Nov 2021 17:53:58 +0000 (UTC) Received: by mail-qt1-f177.google.com with SMTP id f20so14079403qtb.4 for ; Sun, 28 Nov 2021 09:54:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CTle792AODDh5EJBSlHCgdnz2AP0iG3Ix/URPyjXa5E=; b=RtOlkRdAomBbT15PtF6/a66q7AXbagD17hRcpWA8Cg7j+2R+Y5caeki5gdtHsNJtxH KVXTXM/Rke4rD4CLyGs9uJ81OBrFhpsV0venEl05DEQnmsZxmGsAUyU4AQwqbhbagkUy adEcQz4Qs9AsKZPe0LW6+kCFd53UWvzdK+qaishkyhnn6ClXA9viJ99T0t6rKC1HHXE6 D9lu5ZdlDSWInM63lN+YlNigss233KRe/Aad1LrBvH6up3sj4M7wC4fzlbZEQDQhgDO9 BK3AGSpsVeyzj/k4zyXiyBB3kd6QZsa8Dpks/RcN54FAEmkg7CiOxRMsHc9T3AaFpm82 pXpA== X-Gm-Message-State: AOAM530nSlNOk9qf/tVoMgf8LOkNqqdjzf1Lxka+1uXLSXNuYs6V4/d2 YuEY/iRnlVGktKl3Ycw61xA= X-Google-Smtp-Source: ABdhPJx25AEVnfH0h4sZET5x0dxImad0u4ySfFGiKfI+WvQd75qCTeFgZjdPUL+9cNE2+e8o/NeT8g== X-Received: by 2002:ac8:5b87:: with SMTP id a7mr38253502qta.196.1638122044539; Sun, 28 Nov 2021 09:54:04 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id r16sm7298126qta.46.2021.11.28.09.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 09:54:03 -0800 (PST) Date: Sun, 28 Nov 2021 12:54:00 -0500 From: Dennis Zhou To: Yury Norov Cc: Joe Perches , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , "Paul E. McKenney" , "Rafael J. Wysocki" , Alexander Shishkin , Alexey Klimov , Amitkumar Karwar , Andi Kleen , Andrew Lunn , Andrew Morton , Andy Gross , Andy Lutomirski , Andy Shevchenko , Anup Patel , Ard Biesheuvel , Arnaldo Carvalho de Melo , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christoph Hellwig , Christoph Lameter , Daniel Vetter , Dave Hansen , David Airlie , David Laight , Dennis Zhou , Dinh Nguyen , Geetha sowjanya , Geert Uytterhoeven , Greg Kroah-Hartman , Guo Ren , Hans de Goede , Heiko Carstens , Ian Rogers , Ingo Molnar , Jakub Kicinski , Jason Wessel , Jens Axboe , Jiri Olsa , Jonathan Cameron , Juri Lelli , Kalle Valo , Kees Cook , Krzysztof Kozlowski , Lee Jones , Marc Zyngier , Marcin Wojtas , Mark Gross , Mark Rutland , Matti Vaittinen , Mauro Carvalho Chehab , Mel Gorman , Michael Ellerman , Mike Marciniszyn , Nicholas Piggin , Palmer Dabbelt , Peter Zijlstra , Petr Mladek , Randy Dunlap , Rasmus Villemoes , Roy Pledge , Russell King , Saeed Mahameed , Sagi Grimberg , Sergey Senozhatsky , Solomon Peachy , Stephen Boyd , Stephen Rothwell , Steven Rostedt , Subbaraya Sundeep , Sudeep Holla , Sunil Goutham , Tariq Toukan , Tejun Heo , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vincent Guittot , Vineet Gupta , Viresh Kumar , Vivien Didelot , Vlastimil Babka , Will Deacon , bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 7/9] lib/cpumask: add num_{possible,present,active}_cpus_{eq,gt,le} Message-ID: References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-8-yury.norov@gmail.com> <8f389151c39a8a5b6b31d5238cb680305225d9f2.camel@perches.com> <20211128174320.GA304543@lapt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211128174320.GA304543@lapt> X-Stat-Signature: 95o831j7mn7my55pi6rhoas8rs8554nb Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8D52690000A5 X-HE-Tag: 1638122038-39685 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Sun, Nov 28, 2021 at 09:43:20AM -0800, Yury Norov wrote: > On Sun, Nov 28, 2021 at 09:07:52AM -0800, Joe Perches wrote: > > On Sat, 2021-11-27 at 19:57 -0800, Yury Norov wrote: > > > Add num_{possible,present,active}_cpus_{eq,gt,le} and replace num_*_cpus() > > > with one of new functions where appropriate. This allows num_*_cpus_*() > > > to return earlier depending on the condition. > > [] > > > diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c > > [] > > > @@ -103,7 +103,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > > > * if platform didn't set the present map already, do it now > > > * boot cpu is set to present already by init/main.c > > > */ > > > - if (num_present_cpus() <= 1) > > > + if (num_present_cpus_le(2)) > > > init_cpu_present(cpu_possible_mask); > > > > ? is this supposed to be 2 or 1 > > X <= 1 is the equivalent of X < 2. > > > > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c > > [] > > > @@ -593,7 +593,7 @@ static int __init pcc_cpufreq_init(void) > > > return ret; > > > } > > > > > > - if (num_present_cpus() > 4) { > > > + if (num_present_cpus_gt(4)) { > > > pcc_cpufreq_driver.flags |= CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING; > > > pr_err("%s: Too many CPUs, dynamic performance scaling disabled\n", > > > __func__); > > > > It looks as if the present variants should be using the same values > > so the _le test above with 1 changed to 2 looks odd. > I think the confusion comes from le meaning less than rather than lt. Given the general convention of: lt (<), le (<=), eg (=), ge (>=), gt (>), I'd consider renaming your le to lt. Thanks, Dennis