From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D0AC433F5 for ; Sun, 28 Nov 2021 04:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CDC66B0075; Sat, 27 Nov 2021 23:47:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DC16B0078; Sat, 27 Nov 2021 23:47:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345826B007B; Sat, 27 Nov 2021 23:47:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 26BE76B0075 for ; Sat, 27 Nov 2021 23:47:57 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E01C61842ACA7 for ; Sun, 28 Nov 2021 04:47:46 +0000 (UTC) X-FDA: 78857106132.16.E640B50 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by imf24.hostedemail.com (Postfix) with ESMTP id E0746B0000AE for ; Sun, 28 Nov 2021 04:47:41 +0000 (UTC) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4J1wvh31dgzNL; Sun, 28 Nov 2021 05:47:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1638074864; bh=T0svUg/TJeCaOj3VBZ/3tRgBnlIZMjU65z9Fv+g5zQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nn7s8QPTQ/loie98xkMYWvJAWdNi0ygFbehqQ63G9aASvWbHHSf28+XNOM2IsqPek Id9Qk7aFHuFwrGibBi8TresAAu9XqBcHIi12aTTvDPBLXczkWFqaVeOOJqwU7nzdju cV9IwxL2w6Fd22ryYwl1Sh9x2PviA4Kf1ikAu3uR5SMygCLmnTRZxshC+MEAGrH0Kv tsp5I9URKJw3bR68w4MVuWQ2xdmfd6DgYPrQCMsS55RcJLwTkVCCw/V2t3AdcHjMnW QCHQOrGKek5wpaMAmZUhPLRcHZ38Wx/IlUleKYu8VrTTTyi1x1pbkvgBzAZLAICths 2w9BfRFMcSpxg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at mail Date: Sun, 28 Nov 2021 05:47:43 +0100 From: =?iso-8859-2?B?TWljaGGzoE1pcm9zs2F3?= To: Yury Norov Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, kvm@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 3/9] all: replace bitmap_weigth() with bitmap_{empty,full,eq,gt,le} Message-ID: References: <20211128035704.270739-1-yury.norov@gmail.com> <20211128035704.270739-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <20211128035704.270739-4-yury.norov@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E0746B0000AE X-Stat-Signature: 854qyeq1b1snenyr9wpt5qf7nhyaf7yo Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=rere.qmqm.pl header.s=1 header.b=Nn7s8QPT; dmarc=pass (policy=reject) header.from=rere.qmqm.pl; spf=pass (imf24.hostedemail.com: domain of mirq-linux@rere.qmqm.pl designates 91.227.64.183 as permitted sender) smtp.mailfrom=mirq-linux@rere.qmqm.pl X-HE-Tag: 1638074861-489371 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 27, 2021 at 07:56:58PM -0800, Yury Norov wrote: > bitmap_weight() counts all set bits in the bitmap unconditionally. > However in some cases we can traverse a part of bitmap when we > only need to check if number of set bits is greater, less or equal > to some number. >=20 > This patch replaces bitmap_weight() with one of > bitmap_{empty,full,eq,gt,le), as appropriate. >=20 > In some places driver code has been optimized further, where it's > trivial. [...] I think this patch needs to be split. bitmap_full/empty() conversions can be separated (don't need the bitmap_weight_*() functions) and not all changes are trivial. Besides, gathering and checking all the acks needed into one patch seems problematic. Best Regards, Micha=B3=A0Miros=B3aw