From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24570C433F5 for ; Sun, 28 Nov 2021 01:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CB9B6B0075; Sat, 27 Nov 2021 20:51:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27A526B0078; Sat, 27 Nov 2021 20:51:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11BD26B007B; Sat, 27 Nov 2021 20:51:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 0178D6B0075 for ; Sat, 27 Nov 2021 20:51:09 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AF8A6183A39B5 for ; Sun, 28 Nov 2021 01:50:59 +0000 (UTC) X-FDA: 78856660554.27.3DFD47C Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 64BF120019C4 for ; Sun, 28 Nov 2021 01:50:58 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id y14-20020a17090a2b4e00b001a5824f4918so12494331pjc.4 for ; Sat, 27 Nov 2021 17:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ys5xSp8TMHje4lkwagfboQK99rlmdyclUqc40aH5Xfc=; b=JJOISWgIQ7wesuYZIUyZ8YTvD93vtYYWCXpfoY5Xjiptsb/c/6A8Qt0ghl68FPzuuW RcHn3i6d+k+aYpTNzHFoicSvQWW1IaZ/fNNkcM0PpOn2zy/M9mFyuhc8vIeDm9liWaCt H16c8kzlw5FLBZaGYeNosXob9TEcToUUr/mHUnmdiFCbaeCoiQuyTQjYV5GdrTasP7II bw60jyoMg6YcXpFUW5X7r1FzNUeZmQszk455JFn+kbjr2shcdZVhqayQwih2uqXXwuzc JIA2RCCN0BqI59sdeGLuAwHBkfAMzPAdR7xh2WEB5stJk1x6S/XlLMQpQ9UuxV1xRNYO N1vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ys5xSp8TMHje4lkwagfboQK99rlmdyclUqc40aH5Xfc=; b=SYtzAOHmtgA4KjDhPlbAY3BhmnKR9hXUsnGqjFbzRgEezj0Hn5RQZgsIJ9v3Q9xrcu D4qJaihx49hi6IzEUbpsqh3Ok3kv3Ka+YoVe8nuWZg5zPGBQ5i5W/V4AH84Q/xS06aOw hFZOryX0tiAyspLYUGQe4374jHCnl3+ZT1LPShvXUhZ0t5Q+bNE+JX/KPCRoz1c3QJT8 1cJCj6Qa2f2gVtOBtm4MIWe+BtG8kIAyPg+U/29f+2d/KMwPAZMqF8zymmxBq9SUZtJ1 YrZf8HC57ZzdbGsngTRRmS0T35KsTA2/uQ4rUON8cUMYJdCYdW3fqYcXVu54imHG8SwT uiig== X-Gm-Message-State: AOAM530SPc1qPG2tdCuPXah/Jz2bqkYs4Uvz5QUu6E3XzlhU90JVSLzS it7CF9mt5ol5szql1b4Fx/M= X-Google-Smtp-Source: ABdhPJwRmBN5bgq7gesTKrXdzGhmnX4TF8GBRT5ARwRzCP8r0GrmW5VR1rkYDfo3JlQIN/mpfZD2Ow== X-Received: by 2002:a17:903:245:b0:143:c5ba:8bd8 with SMTP id j5-20020a170903024500b00143c5ba8bd8mr50486892plh.64.1638064258317; Sat, 27 Nov 2021 17:50:58 -0800 (PST) Received: from localhost ([103.99.179.247]) by smtp.gmail.com with ESMTPSA id f21sm12503537pfe.69.2021.11.27.17.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Nov 2021 17:50:57 -0800 (PST) Date: Sun, 28 Nov 2021 09:50:53 +0800 From: Calvin Zhang To: Andrew Morton Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Rob Herring , Frank Rowand , Catalin Marinas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH] mm: kmemleak: Ignore kmemleak scanning on CMA regions Message-ID: References: <20211126024711.54937-1-calvinzhang.cool@gmail.com> <20211127160718.54e82aa93c977a367404a9e3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211127160718.54e82aa93c977a367404a9e3@linux-foundation.org> X-Stat-Signature: xxxwcix4pben9cjkrih5mt7h979kdqca Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JJOISWgI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of calvinzhang.cool@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=calvinzhang.cool@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 64BF120019C4 X-HE-Tag: 1638064258-624568 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 27, 2021 at 04:07:18PM -0800, Andrew Morton wrote: >On Fri, 26 Nov 2021 10:47:11 +0800 Calvin Zhang wrote: > >> Just like this: >> commit 620951e27457 ("mm/cma: make kmemleak ignore CMA regions"). >> >> Add kmemleak_ignore_phys() for CMA created from of reserved node. > >Could we please have a full, standalone changelog for this patch? Yes, I will add. > >The 620951e27457 changelog says "Without this, the kernel crashes...". >Does your patch also fix a crash? If so under what circumstances and >should we backport this fix into -stable kernels? No crash occurred. 620951e27457 avoids crashes caused by accessing highmem and it was fixed later. Now kmemleak_alloc_phys() and kmemleak_ignore_phys() skip highmem. This patch is based on the point that CMA regions don't contain pointers to other kmemleak objects, and ignores CMA regions from reserved memory as what 620951e27457 did. -- Thanks Calvin