From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B40DC433EF for ; Tue, 7 Dec 2021 05:17:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86C1F6B0087; Tue, 7 Dec 2021 00:17:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81ABD6B0088; Tue, 7 Dec 2021 00:17:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70AB96B0089; Tue, 7 Dec 2021 00:17:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 647FF6B0087 for ; Tue, 7 Dec 2021 00:17:06 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2967D1815BBD7 for ; Tue, 7 Dec 2021 05:16:56 +0000 (UTC) X-FDA: 78889838832.21.EE602EE Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf07.hostedemail.com (Postfix) with ESMTP id BCA7A10000A8 for ; Tue, 7 Dec 2021 05:16:55 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id o4so12276472pfp.13 for ; Mon, 06 Dec 2021 21:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7rVpB2obUtQAzy/ztIP86+jcl70yMLbAUkD64M1M/30=; b=BOVegIgTDmQbCpRQw/zV0k4oGhCWdbKE4qF2A2ozvwbC4YhQqTcfY4nQXDS9hDe6ae cwvPZg33AGOgP/IDpCxVgAsHH0i+r643oDXTybiBrmSPMp1gJDNSWqJD2ybOSiXRuXFD GMS9vHkdixiVyc9XJ+iZSFOqz0FeLkeXwVPwQKdyK+nPyjyCRbyG66/EH5hYc47syX9c IXbZwPin4q7MBKLwGTRb2KQdnE0+J35pgZGcKMLlRxv3sXHVPb3plzCIEMLyXIQh2Bmw dl1INbt9UNMcqv6KBs557x2FGU9uiskpwcYc9oGbjuC5t7couyzdBaP8Uqeyw4TwjBQv f/cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7rVpB2obUtQAzy/ztIP86+jcl70yMLbAUkD64M1M/30=; b=6UuCU7sxW3BPumRhNk+cOZOZC14fm62aqNTD6b0J38l1WgPM8M8te/tkv/iJpE8Npu 2ugXpBds6jB+EC26v6SCPYNVZbntC1jar2KQzj5g4yA0h52yGHY7YMGMYdkh8dKY7g97 uOINw4UK40VZ6aDP4PYuysJYJRw4VnueJIAsOh3y+CEEf1NEYDgfK12dLoGcPynHyPyE ZbiSq7eTm3ylIiQaBjR+WCj0ByFVfXefoIAZv0O9S5uueN3zOYjokyeaP7YQu/bbP/ja N4/POyMjMWWBWy0LDDOPV3YVBnoRWmTbo9Pc/Vcuk6rPHz1Wx90m7x5c1UVj/ofGC2xJ sbzg== X-Gm-Message-State: AOAM532B5vA0Xw9Hhs2zoCQsGA2m23u9N/RcBw7O0Kn7NdH8xd5RWMVW g0xEzfuFnFuBUHk1pxwqzgE= X-Google-Smtp-Source: ABdhPJx+gpWR1cKsPRdHy8PHWH4WEek0lo348LJSSLFYC94Bdqvm8W1uF0WZlv/OYOdsjP5xpyRorw== X-Received: by 2002:a05:6a00:2151:b0:4a2:5c9a:f0a9 with SMTP id o17-20020a056a00215100b004a25c9af0a9mr41931909pfk.39.1638854214595; Mon, 06 Dec 2021 21:16:54 -0800 (PST) Received: from localhost ([1.157.14.188]) by smtp.gmail.com with ESMTPSA id h186sm13852826pfg.59.2021.12.06.21.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 21:16:53 -0800 (PST) Date: Tue, 7 Dec 2021 16:16:50 +1100 From: Balbir Singh To: yong w Cc: Andrew Morton , "Peter Zijlstra (Intel)" , mingo@kernel.org, LKML , Linux MM , yang.yang29@zte.com.cn, wang.yong12@zte.com.cn Subject: Re: [PATCH v2 linux-next] delayacct: track delays from memory compact Message-ID: References: <1638619795-71451-1-git-send-email-wang.yong12@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BCA7A10000A8 X-Stat-Signature: zfkpg4bbc6xh4xbhisqg4bff98ph7y3e Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BOVegIgT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of bsingharora@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=bsingharora@gmail.com X-HE-Tag: 1638854215-550200 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 05, 2021 at 07:08:02PM +0800, yong w wrote: > Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6=9C=885= =E6=97=A5=E5=91=A8=E6=97=A5 16:17=E5=86=99=E9=81=93=EF=BC=9A > > > > On Sat, Dec 04, 2021 at 04:09:55AM -0800, yongw.pur@gmail.com wrote: > > > From: wangyong > > > > > > Delay accounting does not track the delay of memory compact. > > > When there is not enough free memory, tasks can spend > > > a amount of their time waiting for compact. > > > > > > To get the impact of tasks in direct memory compact, measure > > > the delay when allocating memory through memory compact. > > > > > > > Should we call this DIRECT_COMPACT and through documentation > > or name change imply that this won't work for kcompactd the > > kernel thread - based on my reading of the patches. > > > Using DIRECT_COMPACT is a little redundant=EF=BC=8Cbecause the > delayacct stats of delay accounting is specific to tasks, it has > nothing to do with kcompactd, which is similar to the RECLAIM field. > What would we expect when we call delayacct -p to be output? Yes, I agree with your comment on the reclaim field. Don't feel to strongly, but it can be confusing that kcompactd has spent no time in compact'ing? Not that delayacct is used for kernel threads, but I am not sure if that use case exists today. Balbir Singh.