From: Matthew Wilcox <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Michal Hocko <mhocko@suse.com>,
akpm@linux-foundation.org, rientjes@google.com,
hannes@cmpxchg.org, guro@fb.com, riel@surriel.com,
minchan@kernel.org, kirill@shutemov.name, aarcange@redhat.com,
christian@brauner.io, hch@infradead.org, oleg@redhat.com,
david@redhat.com, jannh@google.com, shakeelb@google.com,
luto@kernel.org, christian.brauner@ubuntu.com,
fweimer@redhat.com, jengelh@inai.de, timmurray@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 1/2] mm: protect free_pgtables with mmap_lock write lock in exit_mmap
Date: Mon, 6 Dec 2021 18:52:28 +0000 [thread overview]
Message-ID: <Ya5b7NEKGr57rKh3@casper.infradead.org> (raw)
In-Reply-To: <CAJuCfpEZi=4V7=nD-4gWi=QyQ8-=ezwmx80twndtoPpZSCzEGQ@mail.gmail.com>
On Mon, Dec 06, 2021 at 10:35:03AM -0800, Suren Baghdasaryan wrote:
> > Other than that looks OK to me. Maybe we want to add an explicit note
> > that vm_ops::close cannot take mmap_sem in any form. The changelog
> > should also mention that you have considered remove_vma and its previous
> > no MM locking assumption. You can argue that fput is async and close
> > callback shouldn't really need mmap_sem.
>
> Should I post another version of this patch with the patch description
> clarifying these points and additional comments as you suggested?
fyi, vm_ops->close() is already called with the mmap_sem held for write
in __split_vma(). If that needs to be documented, it's a separate patch
because it's absolutely not a consequence of this patch.
next prev parent reply other threads:[~2021-12-06 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 23:59 Suren Baghdasaryan
2021-11-24 23:59 ` [PATCH v2 2/2] mm/oom_kill: allow process_mrelease to run under mmap_lock protection Suren Baghdasaryan
2021-11-29 11:23 ` [PATCH v2 1/2] mm: protect free_pgtables with mmap_lock write lock in exit_mmap Michal Hocko
2021-12-06 18:35 ` Suren Baghdasaryan
2021-12-06 18:52 ` Matthew Wilcox [this message]
2021-12-07 10:03 ` Michal Hocko
2021-12-07 10:09 ` Michal Hocko
2021-12-07 16:50 ` Suren Baghdasaryan
2021-12-07 21:54 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5b7NEKGr57rKh3@casper.infradead.org \
--to=willy@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=david@redhat.com \
--cc=fweimer@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jannh@google.com \
--cc=jengelh@inai.de \
--cc=kernel-team@android.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleg@redhat.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox