From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930BEC433F5 for ; Mon, 6 Dec 2021 06:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2B156B007B; Mon, 6 Dec 2021 01:58:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDABE6B007D; Mon, 6 Dec 2021 01:58:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACA066B007E; Mon, 6 Dec 2021 01:58:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 9D6AE6B007B for ; Mon, 6 Dec 2021 01:58:23 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 538B98249980 for ; Mon, 6 Dec 2021 06:58:13 +0000 (UTC) X-FDA: 78886465266.23.2DA4206 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 7F325900009A for ; Mon, 6 Dec 2021 06:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t59vrRjhc1dnfsnCGAwarRQWg1GUsm2sj5AUDx208yQ=; b=CTLKc5ypaxHsUEM4UFv/VWWR8e 1Jjrns6f2qNN8sOL9F1zSimniu4P1k2mPD+dCHdOS+ql6bnlXpEx5AYEXwHY9HkC98X09sC6BDwp+ xsGznbh+rmXA4rUMmHhTeL886rtkCan9QAkuy0LD/IU2QP9+jQ8mBFgJRiqoSPughYe/znuj24mH1 5AEFWiWPgzVH6yqmAGfg2lLMRIYicsEyFAzQ+2RjRyCiES84jD8qiVDTn/JmjJP4MQXzD1IDj6kb2 a1aanJ2FwHqMjtf/wD7ANRHnkkr3hht29gh9ypfa9s5jIj9E/0vLkG2xIsYvq3FPrpWq2yb9Oh/sZ qUHT8Mcg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu7ww-002inz-DU; Mon, 06 Dec 2021 06:58:10 +0000 Date: Sun, 5 Dec 2021 22:58:10 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] block: move direct_IO into our own read_iter handler Message-ID: References: <20211203153829.298893-1-axboe@kernel.dk> <20211203153829.298893-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211203153829.298893-3-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7F325900009A X-Stat-Signature: m7pcsfpxmxp6j1esznpmj6dximdx6p3f Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CTLKc5yp; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+a61e3fda1d3223581906+6679+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a61e3fda1d3223581906+6679+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1638773892-375176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 03, 2021 at 08:38:29AM -0700, Jens Axboe wrote: > Don't call into generic_file_read_iter() if we know it's O_DIRECT, just > set it up ourselves and call our own handler. This avoids an indirect call > for O_DIRECT. > > Fall back to filemap_read() if we fail. Please also do it for the write side, having a partial ->direct_IO is a really bad idea.