From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771CBC433F5 for ; Tue, 7 Dec 2021 23:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B69B6B0073; Tue, 7 Dec 2021 18:34:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73CA26B0074; Tue, 7 Dec 2021 18:34:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DC816B0075; Tue, 7 Dec 2021 18:34:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 4B7906B0073 for ; Tue, 7 Dec 2021 18:34:27 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E84C38248D52 for ; Tue, 7 Dec 2021 23:34:16 +0000 (UTC) X-FDA: 78892604112.03.3CBF8FB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 8DBE8B000182 for ; Tue, 7 Dec 2021 23:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Dd+SCrzB7JWbhzw7xRm3UlZciOw/vMHq8v77nVO1WHg=; b=pFLMshcojgCLkHpUOHmnrWNe73 gVy4BaXE6UnY7Q76+BmnZtVNgKZVx7m2UY7VNUV0ojECgELrm6k3X5s0bgWqkdp3/BW4PBiGXtm3C EUQJw5JaS2wkrh9H65kTyNQXBuoe5pHGGyDw/2zoJTarhvjUkl5gmYCcg0f3StyHRsCnbzpQCdWiS XumRPnUB+L1F+QEQcP9MTXrBIs3IXFr2S0uSifcFZHLm8di0Zs864ynGTR2mQa2zuWm+hcPVni+5L G8gLrDlMqv7tDdPRSZlLH0EnGXxzpwJegBIeQByJVyOnBnUt1v2nGu1/tA8VHWMXy2FktMdQi+PVt 0dja8wFQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mujyC-007sJY-Vr; Tue, 07 Dec 2021 23:34:01 +0000 Date: Tue, 7 Dec 2021 23:34:00 +0000 From: Matthew Wilcox To: Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, shakeelb@google.com, ktkhai@virtuozzo.com, shy828301@gmail.com, guro@fb.com, vbabka@suse.cz, vdavydov.dev@gmail.com, raquini@redhat.com, mhocko@suse.com, david@redhat.com Subject: Re: [PATCH v2 1/1] mm/vmscan.c: Prevent allocating shrinker_info on offlined nodes Message-ID: References: <20211207224013.880775-1-npache@redhat.com> <20211207224013.880775-2-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211207224013.880775-2-npache@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8DBE8B000182 X-Stat-Signature: na8wqhipby1mop73nye98rb5d1je3abp Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pFLMshco; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1638920055-680591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 07, 2021 at 05:40:13PM -0500, Nico Pache wrote: > +++ b/mm/vmscan.c > @@ -222,13 +222,16 @@ static int expand_one_shrinker_info(struct mem_cgroup *memcg, > int size = map_size + defer_size; > > for_each_node(nid) { > + int tmp = nid; > pn = memcg->nodeinfo[nid]; > old = shrinker_info_protected(memcg, nid); > /* Not yet online memcg */ > if (!old) > return 0; > > - new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); > + if(!node_online(nid)) > + tmp = numa_mem_id(); > + new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, tmp); > if (!new) Why should this be fixed here and not in, say, kvmalloc_node()?