From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6CA7C433EF for ; Mon, 22 Nov 2021 13:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43A9A6B0072; Mon, 22 Nov 2021 08:36:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E95C6B0073; Mon, 22 Nov 2021 08:36:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B1C56B0074; Mon, 22 Nov 2021 08:36:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 1D2366B0072 for ; Mon, 22 Nov 2021 08:36:21 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D3C5489064 for ; Mon, 22 Nov 2021 13:36:10 +0000 (UTC) X-FDA: 78836664900.16.7379DD8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 28C78B000807 for ; Mon, 22 Nov 2021 13:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1cwiZQfpD3SkmGX7XB5Pk6HTisIqRWs63/tTDjYhSDo=; b=k+o80sT5+79Qm730/XvaAGDG5A BpHwobOQQ94NSgZ3vciiiRXYky2AjvmAcJaqZi7Q1UAiJCwMCwIfEH6AtT5xac7z7diFc4xPtdQ18 ymOlkTZocGN+S7TuwPAF3NZH4fYPb9vI3XB0i7p910z2XASjieWlt4gmza50L68t3XDFe3AgMpNmu sKx4cclIHi6x/lA2k7xcPkPskQEcTTS6gwDMua7100Dlf/GrzytZo5P+S+iGWlFmmmHgDpwe53VbA fAe1Bc0KiwbAMibfuCANziYCaBez6ebb/+R0KWj1AwP4GGFWAVTxfIGutZBPOUAhyU891IeK5iGld NfQpNAZQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mp9UM-00CszC-Gr; Mon, 22 Nov 2021 13:36:06 +0000 Date: Mon, 22 Nov 2021 13:36:06 +0000 From: Matthew Wilcox To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka Subject: Re: [PATCH] mm,fs: Split dump_mapping() out from dump_page() Message-ID: References: <20211121121056.2870061-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 28C78B000807 X-Stat-Signature: mkqidzy1nr7rexuhg8kpiop3djyese6t Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k+o80sT5; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1637588167-308100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 22, 2021 at 08:11:32AM +0100, Michal Hocko wrote: > On Sun 21-11-21 12:10:56, Matthew Wilcox wrote: > > dump_mapping() is a big chunk of dump_page(), and it'd be handy to be > > able to call it when we don't have a struct page. Split it out and move > > it to fs/inode.c. Take the opportunity to simplify some of the debug > > messages a little. > > Makes sense. I haven't checked the head files inclusion side of this but > I suspect mm heads do include uaccess.h. Not sure inode.c does as well. It does ... convolutedly: linux/fs.h linux/percpu-rwsem.h linux/rcuwait.h linux/sched/signal.h linux/sched/task.h linux/uaccess.h There may be shorter paths to including that file, but that's the one that's actually used according to cpp. fs/inode.c includes linux/mm.h, so it also gets it through linux/pgtable.h x86/include/asm/pgtable.h x86/include/asm/pkru.h x86/include/asm/fpu/xstate.h which is probably not how you think the mm files get uaccess.h, but again, that's the first way that cpp tells me it gets pulled in. Our header files remain a mess. > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Michal Hocko Thanks!