From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828C8C433EF for ; Wed, 17 Nov 2021 13:20:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2AFAD61B1E for ; Wed, 17 Nov 2021 13:20:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2AFAD61B1E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BB51E6B0073; Wed, 17 Nov 2021 08:20:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B63C86B0074; Wed, 17 Nov 2021 08:20:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A52566B0078; Wed, 17 Nov 2021 08:20:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 97A566B0073 for ; Wed, 17 Nov 2021 08:20:16 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 69B7687C95 for ; Wed, 17 Nov 2021 13:20:06 +0000 (UTC) X-FDA: 78818480412.15.9780AB9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 772097001705 for ; Wed, 17 Nov 2021 13:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GmiZj8sWSkK1ZozqITiUiasPtEGPR1td8EgcpndVpcE=; b=kTQgHYPwq0Nh1svgre1DlvBxJq DeG3iBpQNABdRVrRHJq3Pb+qjLPy7nS2l/nQtO1NvlrxaErll1X9w0XEDKy6IAtpnXiz5oBaNuTEx OhRcDnwSkhAH/oNKXe66vJ1ANUpf9o3MFh+VFkZXpaYlYERKvqrOwwO1+wrnXOSqWPCm+75wZJ2Xk fwfOByqYshQHmZgVvg7LQrmswqq1IHHw6wk0aY0PERdxzcoJJEfLh2H5qvoIGJKtmvHPXFWfPho0z +N0ENQ47rGFqJzpV/EaJrBXveMrhf+nlYiEPOGHS/zSkTNNR5Fincem4i0f1RjnO3QR7Ibl9Hd5h4 DK+gf7KA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnKr4-007ctd-K3; Wed, 17 Nov 2021 13:20:02 +0000 Date: Wed, 17 Nov 2021 13:20:02 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: David Howells , linux-mm@kvack.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Export PageHeadHuge() Message-ID: References: <163707085314.3221130.14783857863702203440.stgit@warthog.procyon.org.uk> <20211117083623.elcauwjasw2hbuqi@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117083623.elcauwjasw2hbuqi@box.shutemov.name> X-Rspamd-Queue-Id: 772097001705 X-Stat-Signature: agwwri8hoxhyae9n4at748ccgrx5nymi Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kTQgHYPw; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1637155205-110785 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 17, 2021 at 11:36:23AM +0300, Kirill A. Shutemov wrote: > On Tue, Nov 16, 2021 at 01:54:13PM +0000, David Howells wrote: > > Export PageHeadHuge() - it's used by folio_test_hugetlb() and thence by > > folio_file_page() and folio_contains(). > > Maybe move it to page-flag.h instead? It is trivial enough. HUGETLB_PAGE_DTOR is defined in mm.h so there's a bit of a dependency problem there.