From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D28EC433EF for ; Tue, 16 Nov 2021 23:19:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1738A61B95 for ; Tue, 16 Nov 2021 23:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1738A61B95 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 686836B0071; Tue, 16 Nov 2021 18:19:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 636CA6B0072; Tue, 16 Nov 2021 18:19:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7446B0073; Tue, 16 Nov 2021 18:19:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 3E92C6B0071 for ; Tue, 16 Nov 2021 18:19:44 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E4CED18208298 for ; Tue, 16 Nov 2021 23:19:33 +0000 (UTC) X-FDA: 78816362226.13.64E0E7B Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf18.hostedemail.com (Postfix) with ESMTP id 00E0C4002092 for ; Tue, 16 Nov 2021 23:19:33 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id r132so500311pgr.9 for ; Tue, 16 Nov 2021 15:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o10KqWnht6cmB5ddllrxH2n45i3Vp26vix6RdQhB//Q=; b=cvJ87lWGSV1MzgbkcDV37z/bzi6Nbu28fyF5ShxFHGQGJlOl2YGIFJnBKnCeTrGHa+ SpUD/+lJsLMlBYl9jc/ReTO+pMSn9UPikiezuyp1v9V/21EtiCEHcEx4rMKXtb6gl5B3 G8U9TP03x/7ikAhwg7LGbXC1HYDNkfkZa5wzKcP6K5Qyic3bnjvNfDM55mYQMQYmdet6 koRp8IOjLAe5E4H0u+s6LWE896vPgVwZVD1vkM80EwP4AgzN8/5TvDY/GED9OgMjsnLG 1KGsirwnmWPBWR0DRzgTXwT2b2oZcKQW/QTe2Gh2HTDgPJAB4ZSuy63hH81mFN660vxv rpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o10KqWnht6cmB5ddllrxH2n45i3Vp26vix6RdQhB//Q=; b=Eu5SxE8/OmlDf8qESjxv1EqGIsUsv/8To3mIx2xZjGiowEyZBIsITzgPCeyLIg8b+n N2HmiOzTNuIN9BvJmWerWLXc5SRGRMOUJbeanCXcbNl3kXcvVQyfw9osGkxqNJ7uhDNs UQw2nkB98l7p69m7DogKuhpyWOjoFONNZCkP3KKIfW4u3fBzpI20ifBWkFLiq5woHHAJ HKIQljkkfNUGZWenu9BVIDLJJghqRGgLdJKFiWNoIrb9NJaoKnHAyHk8wxgYxqSoT0ip +d3p568Rkz5vgGKl492vuVXGVgwtAYmLbvuXVyVK7Q2zxg/wNAm2V2FjkXJw7K2Uhi95 smcg== X-Gm-Message-State: AOAM5329y9OpwfbB1rwYgGIABPZUUHKevvJ1FBbNYDkAsLpNS2kmCTmt 8K5rcqGn6LlpFmtkISUsYeg= X-Google-Smtp-Source: ABdhPJwIy2PEM8dIrawMJ5qzJBEoPsIjpvEMwZo6vuyNqBtUk9t7FEtOS+nqv0ZiVVPWhCNifk/Tjg== X-Received: by 2002:aa7:8611:0:b0:49f:a5b3:14b4 with SMTP id p17-20020aa78611000000b0049fa5b314b4mr44733165pfn.30.1637104772422; Tue, 16 Nov 2021 15:19:32 -0800 (PST) Received: from nuc10 (d50-92-229-34.bchsia.telus.net. [50.92.229.34]) by smtp.gmail.com with ESMTPSA id om8sm3449228pjb.12.2021.11.16.15.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 15:19:31 -0800 (PST) Date: Tue, 16 Nov 2021 15:19:29 -0800 From: Rustam Kovhaev To: Vlastimil Babka Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, corbet@lwn.net, djwong@kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, dvyukov@google.com Subject: Re: [PATCH v3] slob: add size header to all allocations Message-ID: References: <20211029030534.3847165-1-rkovhaev@gmail.com> <037227db-c869-7d9c-65e8-8f5f8682171d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <037227db-c869-7d9c-65e8-8f5f8682171d@suse.cz> X-Stat-Signature: 73admpux1qrxag53enyyxs1twq9f9h9h Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cvJ87lWG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of rkovhaev@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=rkovhaev@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 00E0C4002092 X-HE-Tag: 1637104773-905537 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 16, 2021 at 12:26:17PM +0100, Vlastimil Babka wrote: > On 10/29/21 05:05, Rustam Kovhaev wrote: > > Let's prepend both kmalloc() and kmem_cache_alloc() allocations with the > > size header. > > It simplifies the slab API and guarantees that both kmem_cache_alloc() > > and kmalloc() memory could be freed by kfree(). > > > > meminfo right after the system boot, x86-64 on xfs, without the patch: > > Slab: 35456 kB > > > > the same, with the patch: > > Slab: 36100 kB > > > > Link: https://lore.kernel.org/lkml/20210929212347.1139666-1-rkovhaev@gmail.com > > Signed-off-by: Rustam Kovhaev > > Sorry for the late reply. I think we can further simplify this. We have: > > static void *slob_alloc(size_t size, gfp_t gfp, int align, > int node, int align_offset) > > Previously there was one caller that passed size as unchanged, align_offset > = 0, the other passed size + SLOB_HDR_SIZE, align_offset = SLOB_HDR_SIZE. > Now both callers do the latter. We can drop the align_offset parameter and > pass size unchanged. slob_alloc() can internally add SLOB_HDR_SIZE to size, > and use SLOB_HDR_SIZE instead of align_offset. Thank you, I'll send a v4.