From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E46C433EF for ; Mon, 15 Nov 2021 13:57:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A64760F5B for ; Mon, 15 Nov 2021 13:57:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A64760F5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1C05F6B007D; Mon, 15 Nov 2021 08:57:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1703F6B007E; Mon, 15 Nov 2021 08:57:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05EEC6B0080; Mon, 15 Nov 2021 08:57:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id EC5DC6B007D for ; Mon, 15 Nov 2021 08:57:40 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ACB4A7FAA2 for ; Mon, 15 Nov 2021 13:57:40 +0000 (UTC) X-FDA: 78811317438.27.1F36D53 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id D276C4002088 for ; Mon, 15 Nov 2021 13:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r8IGU963lEQVH+Im4QzL/H6LDlFZrB01JAXnEqj9dhE=; b=QF6PQmS+MdU8npd8i7JfRrcYd0 jNGbjW8658UbN63zyaUcW0HkELMI3y4qUerLOo/QEsCamN+pGRlDsB0a/NQ8vSXraWDuTrlFF4GPw EWmWOWFcIEQ38nm/XcL6gdXilw4YEJyLiF7uOwpmvPoq4EFMoSRaC1soa6rcwDwtIJVoW2yDRF9Mz P9j85vOQS6VRQ+jzPUjTEQHGEsC02JB0Wglk3wuWe5iDL0NE8VbWhjr27ywOuVIEUu6cpHAXWUYfw 3Ol1gjCFOPxz/ICsDuHSKsjaQOSPuXSugY1/HEDP4aSEuhXGqA0zNQzcArcpQMCSQqhoNvcpegt01 0GuuaN9A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmcUH-005k3T-0t; Mon, 15 Nov 2021 13:57:33 +0000 Date: Mon, 15 Nov 2021 13:57:32 +0000 From: Matthew Wilcox To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Andrea Arcangeli , Yang Shi , Vlastimil Babka , Hugh Dickins , Andrew Morton , Alistair Popple , "Kirill A . Shutemov" Subject: Re: [PATCH RFC v2 2/2] mm: Rework swap handling of zap_pte_range Message-ID: References: <20211115134951.85286-1-peterx@redhat.com> <20211115134951.85286-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211115134951.85286-3-peterx@redhat.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D276C4002088 X-Stat-Signature: fmk8qp468e1xzobcatubbeb3c7yamh8d Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QF6PQmS+; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1636984659-994229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 09:49:51PM +0800, Peter Xu wrote: > Clean the code up by merging the device private/exclusive swap entry handling > with the rest, then we merge the pte clear operation too. > > struct* page is defined in multiple places in the function, move it upward. Is that actually a good thing? There was a time when declaring variables more locally helped compilers with liveness analysis and register allocation. Compilers are probably smarter now.