From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52D2C433EF for ; Mon, 15 Nov 2021 13:57:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8274060F5B for ; Mon, 15 Nov 2021 13:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8274060F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F07C06B0078; Mon, 15 Nov 2021 08:57:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC2376B007D; Mon, 15 Nov 2021 08:57:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4656B007E; Mon, 15 Nov 2021 08:57:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id CE0E66B0078 for ; Mon, 15 Nov 2021 08:57:32 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7AE1982D8B for ; Mon, 15 Nov 2021 13:57:32 +0000 (UTC) X-FDA: 78811317144.26.3B9A581 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id E09A07000081 for ; Mon, 15 Nov 2021 13:57:31 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8FF7C218EF; Mon, 15 Nov 2021 13:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1636984650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jih4qI6AggfEUAhKNi9VniONxyHNSqxNO681tuikjVI=; b=tzaNnaBNlER3txLxMbZqCIIVF+iZSNPk8S8WZ2yZeVfxO4JW3IhAbR8c/FbgZmK6FEfqIg i35q13dddB2RQSH8TXiw2GvWuuAoY3XnjQKNnMbpK/WAO4JvmkSRmtP0q1oeK0pufvoS8z 6BDgoSJ86XGp1Xt9ojggHEEpz3Nds1k= Received: from suse.cz (unknown [10.100.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 450BEA3B84; Mon, 15 Nov 2021 13:57:30 +0000 (UTC) Date: Mon, 15 Nov 2021 14:57:27 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Dennis Zhou , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Steven Rostedt Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Message-ID: References: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E09A07000081 X-Stat-Signature: ejxd1cst8z135bftbjpfhfdxnx8wj1xu Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tzaNnaBN; spf=pass (imf27.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1636984651-415545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2021-11-15 12:38:03, Andy Shevchenko wrote: > On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote: > > On Fri 2021-11-12 13:15:51, Dennis Zhou wrote: > > > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote: > > > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > in NMI") the printk.h is not needed anymore in percpu.h. > > > > > > > > Moreover `make headerdep` complains (an excerpt) > > > > > > > > In file included from linux/printk.h, > > > > from linux/dynamic_debug.h:188 > > > > from linux/printk.h:559 <-- here > > > > from linux/percpu.h:9 > > > > from linux/idr.h:17 > > > > include/net/9p/client.h:13: warning: recursive header inclusion > > > > > > > > Yeah, it's not a root cause of this, but removing will help to reduce > > > > the noise. > > > > > > > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > in NMI") > > > > Yup, the include was there because of printk_func_t definition that > > was removed by the above commit. > > > > Reviewed-by: Petr Mladek > > > > > Hey Andrew, it doesn't seem like I have anything big coming through > > > percpu, do you mind taking this. I might have some stuff due to sh, but > > > I'm still working on that with them. > > > > I assume that either Andrew or Dennis will take this patch. > > I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, > but it seems you have a consensus with Dennis that Andrew is the best > maintainer to take this. So, I'll send v2 with tags and Cc to him. No problem, I am going to take it, in a hour or so. I did not want to make chaos when Denis asked Andrew. But it is not worth resending the patch. Best Regards, Petr