From: Petr Mladek <pmladek@suse.com>
To: Dennis Zhou <dennis@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h
Date: Mon, 15 Nov 2021 10:48:04 +0100 [thread overview]
Message-ID: <YZIs1FvxA0hKylNd@alley> (raw)
In-Reply-To: <YY6vV2zUTdH5SNt5@fedora>
On Fri 2021-11-12 13:15:51, Dennis Zhou wrote:
> On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote:
> > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > in NMI") the printk.h is not needed anymore in percpu.h.
> >
> > Moreover `make headerdep` complains (an excerpt)
> >
> > In file included from linux/printk.h,
> > from linux/dynamic_debug.h:188
> > from linux/printk.h:559 <-- here
> > from linux/percpu.h:9
> > from linux/idr.h:17
> > include/net/9p/client.h:13: warning: recursive header inclusion
> >
> > Yeah, it's not a root cause of this, but removing will help to reduce
> > the noise.
> >
> > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > in NMI")
Yup, the include was there because of printk_func_t definition that
was removed by the above commit.
Reviewed-by: Petr Mladek <pmladek@suse.com>
> Hey Andrew, it doesn't seem like I have anything big coming through
> percpu, do you mind taking this. I might have some stuff due to sh, but
> I'm still working on that with them.
I assume that either Andrew or Dennis will take this patch.
Best Regards,
Petr
next prev parent reply other threads:[~2021-11-15 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:07 Andy Shevchenko
2021-11-12 18:15 ` Dennis Zhou
2021-11-15 9:48 ` Petr Mladek [this message]
2021-11-15 10:38 ` Andy Shevchenko
2021-11-15 13:57 ` Petr Mladek
2021-11-15 14:20 ` Andy Shevchenko
2021-11-15 14:34 ` Petr Mladek
2021-11-15 15:04 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIs1FvxA0hKylNd@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox