From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755B8C433EF for ; Mon, 15 Nov 2021 10:38:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B57D630EF for ; Mon, 15 Nov 2021 10:38:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B57D630EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4C6CB6B007B; Mon, 15 Nov 2021 05:38:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4767A6B007D; Mon, 15 Nov 2021 05:38:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 364BE6B007E; Mon, 15 Nov 2021 05:38:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 22B336B007B for ; Mon, 15 Nov 2021 05:38:18 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CE57F8249980 for ; Mon, 15 Nov 2021 10:38:17 +0000 (UTC) X-FDA: 78810815034.28.ADD9BE4 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf09.hostedemail.com (Postfix) with ESMTP id 02DDA300011D for ; Mon, 15 Nov 2021 10:38:16 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="233663118" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="233663118" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:38:14 -0800 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="671461205" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:38:12 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mmZND-0071tm-OB; Mon, 15 Nov 2021 12:38:03 +0200 Date: Mon, 15 Nov 2021 12:38:03 +0200 From: Andy Shevchenko To: Petr Mladek Cc: Dennis Zhou , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Steven Rostedt Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Message-ID: References: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 02DDA300011D X-Stat-Signature: nucu5jqntoffskpkepqw41pfw5go7cxb Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf09.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-HE-Tag: 1636972696-315477 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote: > On Fri 2021-11-12 13:15:51, Dennis Zhou wrote: > > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote: > > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > in NMI") the printk.h is not needed anymore in percpu.h. > > > > > > Moreover `make headerdep` complains (an excerpt) > > > > > > In file included from linux/printk.h, > > > from linux/dynamic_debug.h:188 > > > from linux/printk.h:559 <-- here > > > from linux/percpu.h:9 > > > from linux/idr.h:17 > > > include/net/9p/client.h:13: warning: recursive header inclusion > > > > > > Yeah, it's not a root cause of this, but removing will help to reduce > > > the noise. > > > > > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > in NMI") > > Yup, the include was there because of printk_func_t definition that > was removed by the above commit. > > Reviewed-by: Petr Mladek > > > Hey Andrew, it doesn't seem like I have anything big coming through > > percpu, do you mind taking this. I might have some stuff due to sh, but > > I'm still working on that with them. > > I assume that either Andrew or Dennis will take this patch. I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, but it seems you have a consensus with Dennis that Andrew is the best maintainer to take this. So, I'll send v2 with tags and Cc to him. Thanks! -- With Best Regards, Andy Shevchenko