From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80790C433F5 for ; Thu, 25 Nov 2021 10:06:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6CB66B0074; Thu, 25 Nov 2021 05:06:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1CC56B0075; Thu, 25 Nov 2021 05:06:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBCE36B007B; Thu, 25 Nov 2021 05:06:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id BB8F86B0074 for ; Thu, 25 Nov 2021 05:06:07 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7FBD6182DA423 for ; Thu, 25 Nov 2021 10:05:57 +0000 (UTC) X-FDA: 78847021218.19.4E6F90C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf04.hostedemail.com (Postfix) with ESMTP id F124F50000BF for ; Thu, 25 Nov 2021 10:05:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 956CC1FD37; Thu, 25 Nov 2021 10:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1637834755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLPULizaw+dBwYMC93K74dbVtddw6M0ydyywTzQqk/g=; b=raCxzSygda+EyfOy/HkKqzNIozsd/tth4uNMD+gAzqhgwmCtE84LczdR0N42CyCySfr0vz 4NSscVkTyETAVvpPlsnFZYu5OSG9YFVZUfeeobFwSIPtDtPlqLJfk50KeraCGRB+kz/YIm 6D1DVwZrfgctmB0qd23TV6hQUy4UL9w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1637834755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLPULizaw+dBwYMC93K74dbVtddw6M0ydyywTzQqk/g=; b=hYJaK8EcP6btovpH+1sJkuNWQ89VC0QAgBKNpeivVpR7P3nLfG0eRJAlC+gG/KYla3RL7n 7EE3TtUZ+qLom5Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6439C13F5A; Thu, 25 Nov 2021 10:05:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OTKTFgJgn2GVNgAAMHmgww (envelope-from ); Thu, 25 Nov 2021 10:05:54 +0000 Date: Thu, 25 Nov 2021 11:05:52 +0100 From: Joerg Roedel To: Dave Hansen Cc: Brijesh Singh , Peter Gonda , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH Part2 v5 00/45] Add AMD Secure Nested Paging (SEV-SNP) Hypervisor Support Message-ID: References: <20210820155918.7518-1-brijesh.singh@amd.com> <5f3b3aab-9ec2-c489-eefd-9136874762ee@intel.com> <38282b0c-7eb5-6a91-df19-2f4cfa8549ce@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F124F50000BF X-Stat-Signature: gwkcd9ferfb3boq5c9of7qunrtsuu557 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=raCxzSyg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hYJaK8Ec; spf=pass (imf04.hostedemail.com: domain of jroedel@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=jroedel@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1637834752-856966 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 09:48:14AM -0800, Dave Hansen wrote: > That covers things like copy_from_user(). It does not account for > things where kernel mappings are used, like where a > get_user_pages()/kmap() is in play. The kmap case is guarded by KVM code, which locks the page first so that the guest can't change the page state, then checks the page state, and if it is shared does the kmap and the access. This should turn an RMP fault in the kernel which is not covered in the uaccess exception table into a fatal error. Regards, --=20 J=F6rg R=F6del jroedel@suse.de SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 N=FCrnberg Germany =20 (HRB 36809, AG N=FCrnberg) Gesch=E4ftsf=FChrer: Ivo Totev