From: Matthew Wilcox <willy@infradead.org>
To: Hao Lee <haolee.swjtu@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>, Linux MM <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
vdavydov.dev@gmail.com, Shakeel Butt <shakeelb@google.com>,
cgroups@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: reduce spinlock contention in release_pages()
Date: Thu, 25 Nov 2021 03:30:44 +0000 [thread overview]
Message-ID: <YZ8DZHERun6Fej2P@casper.infradead.org> (raw)
In-Reply-To: <CA+PpKPmy-u_BxYMCQOFyz78t2+3uM6nR9mQeX+MPyH6H2tOOHA@mail.gmail.com>
On Thu, Nov 25, 2021 at 11:24:02AM +0800, Hao Lee wrote:
> On Thu, Nov 25, 2021 at 12:31 AM Michal Hocko <mhocko@suse.com> wrote:
> > We do batch currently so no single task should be
> > able to monopolize the cpu for too long. Why this is not sufficient?
>
> uncharge and unref indeed take advantage of the batch process, but
> del_from_lru needs more time to complete. Several tasks will contend
> spinlock in the loop if nr is very large.
Is SWAP_CLUSTER_MAX too large? Or does your architecture's spinlock
implementation need to be fixed?
next prev parent reply other threads:[~2021-11-25 3:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 15:19 Hao Lee
2021-11-24 15:57 ` Matthew Wilcox
2021-11-25 3:13 ` Hao Lee
2021-11-24 16:31 ` Michal Hocko
2021-11-25 3:24 ` Hao Lee
2021-11-25 3:30 ` Matthew Wilcox [this message]
2021-11-25 8:02 ` Hao Lee
2021-11-25 10:01 ` Michal Hocko
2021-11-25 12:31 ` Hao Lee
2021-11-25 14:18 ` Michal Hocko
2021-11-26 6:50 ` Hao Lee
2021-11-26 10:46 ` Michal Hocko
2021-11-26 16:26 ` Hao Lee
2021-11-29 8:39 ` Michal Hocko
2021-11-29 13:23 ` Matthew Wilcox
2021-11-29 13:39 ` Michal Hocko
2021-11-25 18:04 ` Matthew Wilcox
2021-11-26 6:54 ` Hao Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ8DZHERun6Fej2P@casper.infradead.org \
--to=willy@infradead.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=haolee.swjtu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox