From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A3CC433F5 for ; Wed, 24 Nov 2021 20:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B84E6B0075; Wed, 24 Nov 2021 15:46:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 568846B0078; Wed, 24 Nov 2021 15:46:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430866B007B; Wed, 24 Nov 2021 15:46:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 33CA16B0075 for ; Wed, 24 Nov 2021 15:46:41 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ECE0282E3484 for ; Wed, 24 Nov 2021 20:46:30 +0000 (UTC) X-FDA: 78845006940.06.C830978 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf22.hostedemail.com (Postfix) with ESMTP id C243F191C for ; Wed, 24 Nov 2021 20:46:29 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id t11so8033412ljh.6 for ; Wed, 24 Nov 2021 12:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sqvC+dGbfcX6cKXaEroZ5TEDlwO+hSkZLjOyRL/i65M=; b=TcA3Rt9RWkYyKJgneybHJZWfkYCfIKSvcMQ4Fj3n2JNzm8PQCgSgkJc6CbX11j7ved Ld/wWhaiYekfnIUycbvocmFX7/QnDYjTjidQF6q94HaFwbHWuJUwK65XmMk5oHOpvuHj nkm0AGHRbBnWZgpHVB7wqqJZbxH2EDzTeNd4ZMcazbZbZo08aclDlxv+YdtPlv7b1ffo MDU2dZOUBFFk8ID9fp7o3nSSNnBfFMzbsL/FXnpSaDpfUmarOpmyB7je/wGin6cYMstD jJbeVPVLsouO+L6CKq66JWLe5JKFUSxYQiaZRLyQpNZsTyGzE9YgF92kYvdFqA9YQt7b g8cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sqvC+dGbfcX6cKXaEroZ5TEDlwO+hSkZLjOyRL/i65M=; b=QCa33/1KT59AXLEW60VI7VQh+tcwBh9PqUPPwjroCYBMw4L7rwWrgBUc5MhXw5Jzn0 g6Nib+91Z4COvhHkGUF3D9JsF+YsGH62EZDK4m4FPUXW6LZ4uITtfkgoySr0jJiUWJLl RBiLDAkQJfsqFByT/OXWFqTJx7aakAr5zsxOkesLcwgBfPWAZduu0QVhUW59YFUlZveB yKOjm6sCOouTB7tBrm9SJ2gl7UhY8mXtc/0X6xKNXEEFSC9soToz6Gi20iIIqx9D1vPc 9usNPxT6tenotl78XPCQ9jri+/1xqhnQpq90UJcnk9R6nIbv0wgxegpo5n714upaRGYq 7pIQ== X-Gm-Message-State: AOAM5308QWpLfRpxtuQXilZHLeIU6BmO+z2PGkZ3osEZ9ngBlhBLDHYY n5tvricdC8MCOtpK1Q3K+lM= X-Google-Smtp-Source: ABdhPJzwTzo1b7j/+DUso3wsuKzfqD0+SzfyXNXfc3mkgDa231ju+a0J3nvbbccKYDe86sApmqEc+g== X-Received: by 2002:a2e:b88b:: with SMTP id r11mr19691966ljp.280.1637786789149; Wed, 24 Nov 2021 12:46:29 -0800 (PST) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id y22sm79998lfg.272.2021.11.24.12.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 12:46:28 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 24 Nov 2021 21:46:26 +0100 To: Michal Hocko Cc: Uladzislau Rezki , Andrew Morton , Dave Chinner , Neil Brown , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: References: <20211122153233.9924-1-mhocko@kernel.org> <20211122153233.9924-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C243F191C X-Stat-Signature: h6xxyy4o5itoexuzfgn3t31pw8z7o8oc Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TcA3Rt9R; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1637786789-249057 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 23, 2021 at 09:09:08PM +0100, Michal Hocko wrote: > On Tue 23-11-21 20:01:50, Uladzislau Rezki wrote: > [...] > > I have raised two concerns in our previous discussion about this change, > > well that is sad... > > I definitely didn't mean to ignore any of the feedback. IIRC we were in > a disagreement in the failure mode for retry loop - i.e. free all the > allocated pages in case page table pages cannot be allocated. I still > maintain my position and until there is a wider consensus on that I will > keep my current implementation. The other concern was about failures > warning but that shouldn't be a problem when basing on the current Linus > tree. Am I missing something? > Sorry i was answering vice-versa from latest toward first messages :) -- Vlad Rezki