From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294BCC433EF for ; Wed, 24 Nov 2021 13:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 931326B0075; Wed, 24 Nov 2021 08:23:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0B16B0078; Wed, 24 Nov 2021 08:23:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D0B26B007B; Wed, 24 Nov 2021 08:23:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 6EB2B6B0075 for ; Wed, 24 Nov 2021 08:23:59 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 176708DC33 for ; Wed, 24 Nov 2021 13:23:49 +0000 (UTC) X-FDA: 78843891378.26.1568915 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 62F6C9000EC9 for ; Wed, 24 Nov 2021 13:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0eagjiyWCr9C4dEKHRNrT4y4jf0mBVFU+63E9nRYUe0=; b=THFW9Tv08DBQtBHJscFmYp7Us0 SKgkmP9zJz7RBriYOL61HWtIoJJJuW1OO9NcyhorSAqmoo2m22XSEL/J8AMPYGGHujAq3BbXGbpYU 4PdA/nobgD8myLFL32K95AytL1KGAgmO6OT4EdsdjWNpQ92TAEBtEoQpJkfFppJVk3LvCAy8b9sEh JS0/9wYoQ6tPdBOl8yMPmEF7KbDHQTooF+5gJzHfuKZVgbN70OmkAcrrl1VODUGdht3BayWDh1A6S l/SV26/Ib/VFiED1mcJUXYVLIFRkOSK8athcf2pDvggrD4W9+3EW5dDe9wlyVc+GPiRnxLr4D3cHx hNNNVI/g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpsFS-001tWA-PY; Wed, 24 Nov 2021 13:23:42 +0000 Date: Wed, 24 Nov 2021 13:23:42 +0000 From: Matthew Wilcox To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chiminghao , Zeal Robot Subject: Re: [PATCH] mm: Use BUG_ON instead of if condition followed by BUG Message-ID: References: <20211124030849.34998-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124030849.34998-1-chi.minghao@zte.com.cn> X-Rspamd-Queue-Id: 62F6C9000EC9 X-Stat-Signature: p7ajiuwmkh896eu5hm6bfzqsf76ig4fd Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=THFW9Tv0; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1637760225-211310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 03:08:49AM +0000, cgel.zte@gmail.com wrote: > From: chiminghao > > Fix the following coccinelle report: > ./mm/memory_hotplug.c:2210:2-5: > WARNING Use BUG_ON instead of if condition followed by BUG. What coccinelle script is reporting this? > - if (try_remove_memory(start, size)) > - BUG(); > + BUG_ON(try_remove_memory(start, size)); I really, really, really do not like this. For functions with side-effects, this is bad style. If it's a pure predicate, then sure, but this is bad.