From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32307C433EF for ; Wed, 24 Nov 2021 04:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D0B36B0075; Tue, 23 Nov 2021 23:24:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 880686B0078; Tue, 23 Nov 2021 23:24:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F796B007B; Tue, 23 Nov 2021 23:24:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 649386B0075 for ; Tue, 23 Nov 2021 23:24:44 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 15B73183F91ED for ; Wed, 24 Nov 2021 04:24:34 +0000 (UTC) X-FDA: 78842532678.05.FB5538F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 66BAB10000BE for ; Wed, 24 Nov 2021 04:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rb3Kpyd2YBsGfOg22Yvh86fEzaEHWDKx9UmYRlAHfSA=; b=oiOnpw1mu00N/PZX60L/kuEChu 0ScvhPoQ+eKgj8sahtj4kPl3xHG2ddfLsMloX7Mh7QElZehjpxc6ICVlkUokzMkK6KZjwKzdORL/w CxX716pOw7Uqrqa21cvyVzDSL6TJU1XvpDjFiGiXL5P2lcWdA3PAiHpB1ifinoRSaQYNU1W69cy4E BlJtUFrXc518d3EVz2eL5HuVTQVVRvZ9YXvrJahurpt2QxUVrESEQAdL2XLyBewfnULoWTDySnxlT FZ/iAIL80pUeThi4ULfji83hTccFoTlnzuV2Va05A3WXxjw0BWw6jBpnnOBpOoKigCAOeTRHMjLkZ nS4V9/ng==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpjpZ-0009tK-AD; Wed, 24 Nov 2021 04:24:25 +0000 Date: Wed, 24 Nov 2021 04:24:25 +0000 From: Matthew Wilcox To: yangerkun Cc: mike.kravetz@oracle.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH] hugetlbfs: avoid overflow in hugetlbfs_fallocate Message-ID: References: <20211124040818.2219374-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124040818.2219374-1-yangerkun@huawei.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 66BAB10000BE Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oiOnpw1m; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: zzwosq8yp3xh1fh6acejriqep1dgubzj X-HE-Tag: 1637727873-871616 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 24, 2021 at 12:08:18PM +0800, yangerkun wrote: > start = offset >> hpage_shift; > - end = (offset + len + hpage_size - 1) >> hpage_shift; > + end = ((unsigned long long)offset + len + hpage_size - 1) > + >> hpage_shift; + end = DIV_ROUND_UP_ULL(offset + len, hpage_size);