From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E951C433F5 for ; Tue, 23 Nov 2021 20:09:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0B3F6B0072; Tue, 23 Nov 2021 15:09:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBA686B0074; Tue, 23 Nov 2021 15:09:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA9626B0075; Tue, 23 Nov 2021 15:09:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id BCDD96B0072 for ; Tue, 23 Nov 2021 15:09:24 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7E7BA81203F3 for ; Tue, 23 Nov 2021 20:09:14 +0000 (UTC) X-FDA: 78841284228.12.EAA5310 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 1311E10002D0 for ; Tue, 23 Nov 2021 20:09:10 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AEC251FD5A; Tue, 23 Nov 2021 20:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1637698152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=to1JiEtdgAtTYZuUmNGxh55YpOijfzoRjl9rgnGo0kU=; b=rwsoiFBlvBOCmcthSMKTyiXhvbpaatiGRe7XJFXSLF11qVvGpjJErOyVE7J3vW/EXuOp25 Fyu+b6KnNEnn94da7+wIyLCE/3Dgn3WKFCvmkH3v3epiJWa44NdW43rR/nD7RwubwJeFZh gUeXZaoG6uroXUUV+6hX3NSTX8i0zMI= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 85519A3B85; Tue, 23 Nov 2021 20:09:12 +0000 (UTC) Date: Tue, 23 Nov 2021 21:09:08 +0100 From: Michal Hocko To: Uladzislau Rezki Cc: Andrew Morton , Dave Chinner , Neil Brown , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: References: <20211122153233.9924-1-mhocko@kernel.org> <20211122153233.9924-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: p1hn4heuqoojd7931y4gbc11cat5bnxi Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=rwsoiFBl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1311E10002D0 X-HE-Tag: 1637698150-256737 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 23-11-21 20:01:50, Uladzislau Rezki wrote: [...] > I have raised two concerns in our previous discussion about this change, > well that is sad... I definitely didn't mean to ignore any of the feedback. IIRC we were in a disagreement in the failure mode for retry loop - i.e. free all the allocated pages in case page table pages cannot be allocated. I still maintain my position and until there is a wider consensus on that I will keep my current implementation. The other concern was about failures warning but that shouldn't be a problem when basing on the current Linus tree. Am I missing something? -- Michal Hocko SUSE Labs