From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yang Shi <shy828301@gmail.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
linux-mm@kvack.org, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] filemap: Remove PageHWPoison check from next_uptodate_page()
Date: Thu, 25 Nov 2021 14:51:44 +0000 [thread overview]
Message-ID: <YZ+jAILwqdAatZtE@casper.infradead.org> (raw)
In-Reply-To: <20211123192442.f4e74b35a900463c5bc8a675@linux-foundation.org>
On Tue, Nov 23, 2021 at 07:24:42PM -0800, Andrew Morton wrote:
> On Sat, 20 Nov 2021 17:44:29 +0000 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
>
> > Pages are individually marked as suffering from hardware poisoning.
> > Checking that the head page is not hardware poisoned doesn't make
> > sense; we might be after a subpage. We check each page individually
> > before we use it, so this was an optimisation gone wrong.
>
> What were the runtime effects of this bug?
We'd fall back to the slow path when there was no need to do that.
prev parent reply other threads:[~2021-11-25 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 17:44 Matthew Wilcox (Oracle)
2021-11-21 23:35 ` HORIGUCHI NAOYA(堀口 直也)
2021-11-22 19:28 ` Yang Shi
2021-11-24 0:11 ` HORIGUCHI NAOYA(堀口 直也)
2021-11-24 0:32 ` Yang Shi
2021-11-24 0:57 ` Yang Shi
2021-11-24 3:24 ` Andrew Morton
2021-11-25 14:51 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ+jAILwqdAatZtE@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox