From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12ACC433F5 for ; Thu, 25 Nov 2021 20:29:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C4CA6B0074; Thu, 25 Nov 2021 15:29:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14B896B0075; Thu, 25 Nov 2021 15:29:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2EBB6B0078; Thu, 25 Nov 2021 15:29:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id DD7856B0074 for ; Thu, 25 Nov 2021 15:29:11 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A002218116E15 for ; Thu, 25 Nov 2021 20:29:01 +0000 (UTC) X-FDA: 78848591724.18.E835319 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id B247B508BB85 for ; Thu, 25 Nov 2021 20:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iaFSt8plB4g2qCZtRIDKmSInpmSjFYz22dj65sciQlI=; b=cAi7ruXEDoZgqxCH7eyWDQNX+r m3IavACCyhGUn0jcRXwKGMD9YUNZLTYx6R22Kl3QxrbElu0OHNSmzC0tUxqZxZkGHWSJfXcl2Lefw K50ZmRlWa3XZVr3zgKixNrkLyTei9VlKMEqiHCwYSlsFMBIOGFZz0hRHRDubSfUmb+gxCsJeTeg82 0QmzxCD7tesSYrBzT3Brlz+EgAcrcFYosF6iwWI0C2DoaEGZwi6KHHoK+QBgTqohHtgb0Vq3SW956 Q6d6h7oc7zgUmTw/fiUQwjNPKVhbC4mSzY5vU4tKRpQsLxodXugLZacnh70Eu4gcah2w1XcwiN5bP ocS7gDjw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqLMV-007hTy-OC; Thu, 25 Nov 2021 20:28:55 +0000 Date: Thu, 25 Nov 2021 20:28:55 +0000 From: Matthew Wilcox To: Yixuan Cao Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix the type of a parameter Message-ID: References: <20211125194301.19244-1-caoyixuan2019@email.szu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211125194301.19244-1-caoyixuan2019@email.szu.edu.cn> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B247B508BB85 X-Stat-Signature: mgfhkipaow7uknc77cr5hb48errbyq8t Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cAi7ruXE; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1637872133-262330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 26, 2021 at 03:43:01AM +0800, Yixuan Cao wrote: > The type of "last_migrate_reason" in struct page_owner is short. > However, the type of "reason" in the argument list of function > __set_page_owner_migrate_reason is int, > which is inconsistent. Did you try compiling this patch? > Signed-off-by: Yixuan Cao > --- > mm/page_owner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 4f924957ce7a..4c23e910caf9 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -182,7 +182,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order, > __set_page_owner_handle(page_ext, handle, order, gfp_mask); > } > > -void __set_page_owner_migrate_reason(struct page *page, int reason) > +void __set_page_owner_migrate_reason(struct page *page, short reason) > { > struct page_ext *page_ext = lookup_page_ext(page); > struct page_owner *page_owner; > -- > 2.31.1 > > > >