From: Matthew Wilcox <willy@infradead.org>
To: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix the type of a parameter
Date: Thu, 25 Nov 2021 20:28:55 +0000 [thread overview]
Message-ID: <YZ/yBxJlznnraBe2@casper.infradead.org> (raw)
In-Reply-To: <20211125194301.19244-1-caoyixuan2019@email.szu.edu.cn>
On Fri, Nov 26, 2021 at 03:43:01AM +0800, Yixuan Cao wrote:
> The type of "last_migrate_reason" in struct page_owner is short.
> However, the type of "reason" in the argument list of function
> __set_page_owner_migrate_reason is int,
> which is inconsistent.
Did you try compiling this patch?
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
> ---
> mm/page_owner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 4f924957ce7a..4c23e910caf9 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -182,7 +182,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order,
> __set_page_owner_handle(page_ext, handle, order, gfp_mask);
> }
>
> -void __set_page_owner_migrate_reason(struct page *page, int reason)
> +void __set_page_owner_migrate_reason(struct page *page, short reason)
> {
> struct page_ext *page_ext = lookup_page_ext(page);
> struct page_owner *page_owner;
> --
> 2.31.1
>
>
>
>
next prev parent reply other threads:[~2021-11-25 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 19:43 Yixuan Cao
2021-11-25 20:28 ` Matthew Wilcox [this message]
2021-12-01 18:12 Yixuan Cao
2021-12-02 3:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ/yBxJlznnraBe2@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=caoyixuan2019@email.szu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox