From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F40DAC433EF for ; Thu, 25 Nov 2021 20:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FBAE6B0075; Thu, 25 Nov 2021 15:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 684976B0078; Thu, 25 Nov 2021 15:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE796B007B; Thu, 25 Nov 2021 15:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 3E2086B0075 for ; Thu, 25 Nov 2021 15:21:39 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC2BD8BEE2 for ; Thu, 25 Nov 2021 20:21:28 +0000 (UTC) X-FDA: 78848572656.15.88BDD48 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf04.hostedemail.com (Postfix) with ESMTP id A787E50000B7 for ; Thu, 25 Nov 2021 20:21:24 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id b1so18824141lfs.13 for ; Thu, 25 Nov 2021 12:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mnoEOb8Hv954j3i4irIBD7t76uu0fsOSVAr2WZwq1j0=; b=pRWmT9Ia87UdxCoz9ngZywa5cyo1TrHHSDhzi/kxAH03obgBufvviWVuWnNvrgamk7 otTIj5HnTwkGfW5wfpVFFlVSzyrihfOmwk8KHFDX0Z2C+gDI7A8ZwBvBWibGMdeJKY/7 gHBOK5N9+ceIhs+pp+6jJGkJDcCeUdZZPUsHJk9cdIRwuHBe9/RHlwpsDr+bCeQbfq6E JhySC1Ms7V5LkxsiootlkMa7W5tZabwArWAvY5hCtsRVfyzC0zqSBvlo825npiJeONc2 JIopjq2LqZA9FWio6fPspxXNCIc7yyLK8yn4nxoOEqfXIrgOIEtHx2bSZfsYVu2TwQ0P 0cDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mnoEOb8Hv954j3i4irIBD7t76uu0fsOSVAr2WZwq1j0=; b=6n9JiBu2X5a5rAr3cgp9O0JKOO9KrmFxJDX1LiwPmgcvshzavFAcyY2zGeuIdWfl+N NX1BI3OZ1L8oSmFFgbVTUs7u3IN6Kly54SAad6dZ735amS/DEdYBP62Zy83ap6xEAzrs raxPkoUPMglkyBWqS1V9ANLWTHXZy51kXkPQNCDpImXXgVJtCklOmfbWoR/iKQOFG63J fFMq3KZWjIxEIVm2KYY08+bgev57yjZ+qs5VA7waDvGbvjZrw5Aprd8qMQRoIOJoF2f5 WFzqaMWPk+RQU+PSugxLhzH1wsM37VzyMZp9/t0Cxr0d6l2y2S2+23rUD0Q8I3ckP4CV LVHA== X-Gm-Message-State: AOAM532EfRIac+qvX6xVARML9jtMU6A1k9ptEvEIyvQmrqinqYn6gIeQ gtEqm054+jcW3irKOyYbnN86aN5nmMX1zVHy X-Google-Smtp-Source: ABdhPJzv6tVHfjPCNBYsQmVAMCejhhFupK/eFYJ+PY32Yv0mLT+rVrWUAqrkeiZTN0ZKjY9QGhH8qg== X-Received: by 2002:a05:6512:31c4:: with SMTP id j4mr26213026lfe.173.1637871687025; Thu, 25 Nov 2021 12:21:27 -0800 (PST) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id m20sm339742lfu.241.2021.11.25.12.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 12:21:25 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 25 Nov 2021 21:21:23 +0100 To: Michal Hocko Cc: Uladzislau Rezki , Andrew Morton , Dave Chinner , Neil Brown , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: References: <20211122153233.9924-1-mhocko@kernel.org> <20211122153233.9924-3-mhocko@kernel.org> <20211123170238.f0f780ddb800f1316397f97c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ya6k735559uu4zu5d8thaecq1736y1hu X-Rspamd-Queue-Id: A787E50000B7 X-Rspamd-Server: rspam07 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pRWmT9Ia; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1637871684-66604 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Thu 25-11-21 21:03:23, Uladzislau Rezki wrote: > > On Thu, Nov 25, 2021 at 08:24:04PM +0100, Michal Hocko wrote: > > > On Thu 25-11-21 19:02:09, Uladzislau Rezki wrote: > > > [...] > > > > Therefore i root for simplification and OOM related concerns :) But > > > > maybe there will be other opinions. > > > > > > I have to say that I disagree with your view. I am not sure we have > > > other precedence where an allocator would throw away the primary > > > allocation just because a metadata allocation failure. > > > > > Well, i tried to do some code review and raised some concerns and > > proposals. > > I do appreciate your review! No question about that. > > I was just surprised by your reaction that your review feedback had been > ignored because I do not think this is the case. > > We were in a disagreement and that is just fine. It is quite normal to > disagree. The question is whether that disagreement is fundamental and > poses a roadblock for merging. I definitely do not want and mean to push > anything by force. My previous understanding was that your concerns are > mostly about aesthetics rather than blocking further progress. > It is not up to me to block you from further progress and of course it was not my intention. You asked for a review i did it, that is it :) -- Vlad Rezki