From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314C2C433EF for ; Thu, 25 Nov 2021 20:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D5EC6B0074; Thu, 25 Nov 2021 15:03:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7831B6B0075; Thu, 25 Nov 2021 15:03:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 624EB6B0078; Thu, 25 Nov 2021 15:03:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 5512D6B0074 for ; Thu, 25 Nov 2021 15:03:42 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 19FAF181C2202 for ; Thu, 25 Nov 2021 20:03:32 +0000 (UTC) X-FDA: 78848527506.10.AB55DC2 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 50438D0000B1 for ; Thu, 25 Nov 2021 20:03:22 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id i63so14517188lji.3 for ; Thu, 25 Nov 2021 12:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7p/0Jku+qCm+8vv6WBeeFjWQ8UEiYTDZ+FwuFwo6po0=; b=YRu3bS8YBSqpNQWfwxhsfN0YGZIbWkiIfCUxv1eDC9sam9AKQz/3ISYOdcikWR4prR 9edCkBA7vvjZK9G7CSJLvPM098m3CNDwB06TOFBH4nyor3pssFXVarKQu5CmmmkKTH0r LJGOWfTsG+E+Wo65yL77uqreaQbrxOE5FPX5XzR/xP8jfG5lpgDexjQjPMl5gluO2lQj 5nR+W1LCIGKVVpfOHt7GjTl76JploFGn/9GqCg3FkxvDtAqtG858uMWfgOPWNsRqS+uS 2n8J0koPX/lAOAi2eVGbuAnIdEYFQg2juE89kT2Aif658rEl8/peutgiU7CVkbZOfvz5 nw9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7p/0Jku+qCm+8vv6WBeeFjWQ8UEiYTDZ+FwuFwo6po0=; b=JSvc2ql0JveKxqief+Z6ld041PSXy9aX5D4tY2I6FJy2kQ+GB1OFueOtpw/5s+GMFJ 8tGAqmCHB1V8R7LMrwTPxnZbMOd6T4zIpcTrnYTv5ZDxhtrKcGMm3KmPJzO5cn/2yjA7 3UAiJ4iz1FY9hEe+RaZTjh7CmnvXBCuGSF0zHqM/RRAqp7Tdv1GEnREjwbVlJpQI6IyL AqL4EErLAv7TV6uBwo/zzqleVKTvEAWYdQRCJxtcFn7c6G3UckqJN+KQSOKi45OSa76f 2N9H6BVsVEZDL1f4OE1+1nltvGj5p1pm2WmFBlAbAy2pdoM95aP89wqAHCJFrVjRK/Os NryQ== X-Gm-Message-State: AOAM533tCivQqTcOljb8TyKfrOUCNZBXtpI5anolfEJveq1qn5NdUj3r peHMMFMr2JtLI3HGVwbr368= X-Google-Smtp-Source: ABdhPJx4DWJw5wxZ76NVyXRts+DU62de9yu6D2DNcBUWlouwK5XqqpxGD+pcp2WEUnLB3NH0bwseMg== X-Received: by 2002:a2e:5852:: with SMTP id x18mr26523009ljd.184.1637870605782; Thu, 25 Nov 2021 12:03:25 -0800 (PST) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id q13sm336566lfe.121.2021.11.25.12.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 12:03:25 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 25 Nov 2021 21:03:23 +0100 To: Michal Hocko Cc: Uladzislau Rezki , Andrew Morton , Dave Chinner , Neil Brown , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: References: <20211122153233.9924-1-mhocko@kernel.org> <20211122153233.9924-3-mhocko@kernel.org> <20211123170238.f0f780ddb800f1316397f97c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 50438D0000B1 X-Stat-Signature: w4agqw5odroy4yz7mz3qrgau3wxinjb8 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YRu3bS8Y; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1637870602-797480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 25, 2021 at 08:24:04PM +0100, Michal Hocko wrote: > On Thu 25-11-21 19:02:09, Uladzislau Rezki wrote: > [...] > > Therefore i root for simplification and OOM related concerns :) But > > maybe there will be other opinions. > > I have to say that I disagree with your view. I am not sure we have > other precedence where an allocator would throw away the primary > allocation just because a metadata allocation failure. > Well, i tried to do some code review and raised some concerns and proposals. If you do not agree, then of course i will not be arguing here. -- Vlad Rezki