From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC58C433F5 for ; Thu, 25 Nov 2021 19:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F05136B0074; Thu, 25 Nov 2021 14:24:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB3F96B0075; Thu, 25 Nov 2021 14:24:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA24C6B0078; Thu, 25 Nov 2021 14:24:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id CC36F6B0074 for ; Thu, 25 Nov 2021 14:24:16 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 886C28E2DC for ; Thu, 25 Nov 2021 19:24:06 +0000 (UTC) X-FDA: 78848428134.18.940EB26 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id EA2157001A0A for ; Thu, 25 Nov 2021 19:24:03 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 059F221891; Thu, 25 Nov 2021 19:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1637868245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zeEh+Mnsqm3keavvrhJXx22I1VEL7us1czf+Y+aaH7I=; b=OrPZ9cXgr+eP5+r1Hg6nneERBtX3GXPaHmqDh8O4Sx1tert8at9JAoXCKg4qAumtSxKFjL NRQdqU/et+BzzZ2FvhNWOpLZDpmpu3xRhPcUHrmgOMzzdHF5Bf47WU8r0Aee125c/84etf A4rb0kBzALs1hgTa3KrpWoA59sR2Oi4= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C6A20A3B81; Thu, 25 Nov 2021 19:24:04 +0000 (UTC) Date: Thu, 25 Nov 2021 20:24:04 +0100 From: Michal Hocko To: Uladzislau Rezki Cc: Andrew Morton , Dave Chinner , Neil Brown , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: References: <20211122153233.9924-1-mhocko@kernel.org> <20211122153233.9924-3-mhocko@kernel.org> <20211123170238.f0f780ddb800f1316397f97c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EA2157001A0A X-Stat-Signature: mn7dmzdc9q4ub9hj1df96h83zorhihca Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OrPZ9cXg; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1637868243-723548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 25-11-21 19:02:09, Uladzislau Rezki wrote: [...] > Therefore i root for simplification and OOM related concerns :) But > maybe there will be other opinions. I have to say that I disagree with your view. I am not sure we have other precedence where an allocator would throw away the primary allocation just because a metadata allocation failure. In any case, if there is a wider consensus that we really want to do that I can rework. I would prefer to keep the patch as is though. -- Michal Hocko SUSE Labs