From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71156C433EF for ; Wed, 10 Nov 2021 07:03:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0BD1261186 for ; Wed, 10 Nov 2021 07:03:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BD1261186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 41D836B006C; Wed, 10 Nov 2021 02:03:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD766B0071; Wed, 10 Nov 2021 02:03:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 295126B0072; Wed, 10 Nov 2021 02:03:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 17C1A6B006C for ; Wed, 10 Nov 2021 02:03:18 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E06E4181B5EA6 for ; Wed, 10 Nov 2021 07:03:16 +0000 (UTC) X-FDA: 78792129192.12.8D6BB0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9069590000A6 for ; Wed, 10 Nov 2021 07:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636527795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0cadZK7XFbebH7WBSpOeCcH2GLCqGBVv5pJTjTqScgI=; b=MSb6zyufM34Dz/7le2ju8Z/eb/gd2fD9gJrZP5CfMs/HU5ggn5mjxss+POEtqZftBRagQ6 SgsiioYqRuhiMeyeZKCBLXK909YE6L5BHV1D0jJrRfyv9lV6ufk33T2WNJv0JwjscPpF1R 37vAXkdUci9mThxhEajvpXtW5WwOIQo= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-U-fsCjsZMrKru068C8ocvA-1; Wed, 10 Nov 2021 02:03:14 -0500 X-MC-Unique: U-fsCjsZMrKru068C8ocvA-1 Received: by mail-pg1-f198.google.com with SMTP id w13-20020a63934d000000b002a2935891daso1027798pgm.15 for ; Tue, 09 Nov 2021 23:03:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0cadZK7XFbebH7WBSpOeCcH2GLCqGBVv5pJTjTqScgI=; b=fxytavxv+q0qfOqV8Xzl6Rpa9obPMHwgqeUtmC9NJwsgZZvAgf7r6qzQz7yFawpBGK fezMlUlkT28mv2aHaJFURMrxXUEH+ZscME4YIrg29Hej8F5PrkMunAYM/0ErKJvuhk3Q KDYvfxRVxyfl/w+SqziNXZ9jPf8ym21fI16mmGZga1YqRts9/TF74CMGdm0xE29xaO02 R7+YZ8Ou40XQSYFETYYvIl/vGsAB8Uq9VBoMnDkIQ5QKgjPISnQmWrVy/UQZLkV3Zo5j 6QQXH9aRQp1w7IMnjrhZ9F7MqlauWhVTC4E6H7aSBYaOd3TDFRLCklbNymBt8VC67ENg NjLg== X-Gm-Message-State: AOAM531EGOmgmOaHvsDGQsaIOj1y0KE9LIL4r65fE7RnmxALiw++yZaO NdiLPcenLn0hk56QmCV5ktFPDEecZ7aFZdLcX6tywswdC59Wm8tv8Av+Vujgo35+tAyHOpGU2EN rMwiDTxswtJk= X-Received: by 2002:a17:902:d50d:b0:141:ea03:5193 with SMTP id b13-20020a170902d50d00b00141ea035193mr13204507plg.89.1636527793190; Tue, 09 Nov 2021 23:03:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwADuN2McaK3Hz7vOj8bQd5Tyj05xsqo8F8qbby7T4wFIAY2nEuPkvVgYieWrNTWlsrTqt6ig== X-Received: by 2002:a17:902:d50d:b0:141:ea03:5193 with SMTP id b13-20020a170902d50d00b00141ea035193mr13204473plg.89.1636527792955; Tue, 09 Nov 2021 23:03:12 -0800 (PST) Received: from t490s ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id e15sm1645364pfv.131.2021.11.09.23.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 23:03:12 -0800 (PST) Date: Wed, 10 Nov 2021 15:03:06 +0800 From: Peter Xu To: Mina Almasry Cc: David Hildenbrand , Matthew Wilcox , "Paul E . McKenney" , Yu Zhao , Jonathan Corbet , Andrew Morton , Ivan Teterevkov , Florian Schmidt , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap Message-ID: References: <20211107235754.1395488-1-almasrymina@google.com> MIME-Version: 1.0 In-Reply-To: <20211107235754.1395488-1-almasrymina@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9069590000A6 X-Stat-Signature: 4af6umom9tewqyrzgyt6dujgky8k1yjz Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MSb6zyuf; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1636527781-38383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Mina, Sorry to comment late. On Sun, Nov 07, 2021 at 03:57:54PM -0800, Mina Almasry wrote: > diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst > index fdc19fbc10839..8a0f0064ff336 100644 > --- a/Documentation/admin-guide/mm/pagemap.rst > +++ b/Documentation/admin-guide/mm/pagemap.rst > @@ -23,7 +23,8 @@ There are four components to pagemap: > * Bit 56 page exclusively mapped (since 4.2) > * Bit 57 pte is uffd-wp write-protected (since 5.13) (see > :ref:`Documentation/admin-guide/mm/userfaultfd.rst `) > - * Bits 57-60 zero > + * Bit 58 page is a huge (PMD size) THP mapping > + * Bits 59-60 zero > * Bit 61 page is file-page or shared-anon (since 3.5) > * Bit 62 page swapped > * Bit 63 page present > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index ad667dbc96f5c..6f1403f83b310 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1302,6 +1302,7 @@ struct pagemapread { > #define PM_SOFT_DIRTY BIT_ULL(55) > #define PM_MMAP_EXCLUSIVE BIT_ULL(56) > #define PM_UFFD_WP BIT_ULL(57) > +#define PM_HUGE_THP_MAPPING BIT_ULL(58) The ending "_MAPPING" seems redundant to me, how about just call it "PM_THP" or "PM_HUGE" (as THP also means HUGE already)? IMHO the core problem is about permission controls, and it seems to me we're actually trying to workaround it by duplicating some information we have.. so it's kind of a pity. Totally not against this patch, but imho it'll be nicer if it's the permission part that to be enhanced, rather than a new but slightly duplicated interface. Thanks, -- Peter Xu