From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA75C433F5 for ; Mon, 8 Nov 2021 15:57:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AF8661242 for ; Mon, 8 Nov 2021 15:57:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0AF8661242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0D19F6B006C; Mon, 8 Nov 2021 10:57:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0814E6B0072; Mon, 8 Nov 2021 10:57:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB1406B0073; Mon, 8 Nov 2021 10:57:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id DD7E56B006C for ; Mon, 8 Nov 2021 10:57:42 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 66FE67837F for ; Mon, 8 Nov 2021 15:57:39 +0000 (UTC) X-FDA: 78786218238.04.A6D59C1 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf29.hostedemail.com (Postfix) with ESMTP id 65B9D9001A94 for ; Mon, 8 Nov 2021 15:57:37 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id h24so7377606pjq.2 for ; Mon, 08 Nov 2021 07:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=aAjH05HC+Yq1fpsWfaNYfykzHpOqzzS4xldmSGauAaM=; b=U47JQ9Gbtp8jgoX0SWnGU0TaWD8J7Y54lErjWuV0xiAq+NpnBpzUzJzu2+BOHoCWfk SThivXCjXqDs0VvAe64Sgd9iVUu7Uy9bXAcleMtJnQa/QEBXAK9hFhmGheCd2q/ptZ90 DDO81JVBaFhuYzkrbllw8Zyl0JzAmwKZEu+PqBeoufrHPlRRQX53BSyqQogRjlPZSoT7 SeVcu6UQPGlxONCiXDx83aFYBS6J53iY5yasKsJiR9MFDWrF3radP+TE96kXANonIG7u op8Yrtlw1GVPb67r3oPSswMJ8EvRkHBa1wM9+WoC77JIFFHqzqlEW9cre2VA1nFUZY1w xChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=aAjH05HC+Yq1fpsWfaNYfykzHpOqzzS4xldmSGauAaM=; b=WKT/JB6oF808uPh8nqd8EtWPInqBNvfxAjw5WzDqfI5KG0NahkxGcN49qw9jLtnQg6 MOQoGuvYE7dMbw36+Hpnj2ioBj25xvRg1QO+QhkT9UZsD2LFgMiTWu/BAogyLB9idyHY NLcuu6atSBdnOpbbphXDkyCqzAXZ8Bv4dwZgd1AfSlYZuQ77sFtm9LjFMYQPC4FhRQqn K+5K2zGVam+ef/FzMSTBmwNe7Mpa+LxFQMEXZWUNT0Dgar+t+GVljvyjxeGuLZzTBDrK Qc/XOvaBSefhRm1fLbD0ZtqE8cCrnqZus0YPZ4h8I1kPZny8bds4ju9JgkGftg33IY7E q0Pg== X-Gm-Message-State: AOAM530jm2C1eOWereWJK6nkyjhWoEifUYTGlkNMwC6sGZ+d9eMP/2CU U+6Tbge5B3u/ED4mmfCuWQIMana0ysljGw== X-Google-Smtp-Source: ABdhPJysuDsGhta8Eh9p88a5MKNlvAtiuKLqEkwJivaPV5LjcttH3PQSpuwr2xo0o+VYUXzJsmI9zQ== X-Received: by 2002:a05:6214:3004:: with SMTP id ke4mr368613qvb.48.1636387045135; Mon, 08 Nov 2021 07:57:25 -0800 (PST) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id y6sm10409448qkp.116.2021.11.08.07.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 07:57:24 -0800 (PST) Date: Mon, 8 Nov 2021 10:57:23 -0500 From: Johannes Weiner To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: vfs-keep-inodes-with-page-cache-off-the-inode-shrinker-lru.patch Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 65B9D9001A94 X-Stat-Signature: aigor87899kjz7y3fc3fmp15o7axn6x5 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=U47JQ9Gb; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-HE-Tag: 1636387057-410306 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003478, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, I promised to give this patch some more testing exposure while it sits in -mm. We've been steadily rolling this version of the change to our fleet over the last months and it's currently on 20% of FB servers. We have not noticed crashes or performance regressions because of it. (The other 80% is running a previous version of the patch.) The comment in 'series' says "extra cycle" but that was 5.15 :-) Do you think we can get it merged into 5.16? Just to reiterate, without the patch, there is very broad production breakage for FB beyond reduced cache effectiveness. Yes, we lose cache pages prematurely. But a bigger problem is that we lose nonresident info we store in the inodes. This defeats thrash detection, which in turn defeats psi and central reclaim deciscion making. The downstream effects of this are quite severe and widespread: - memory prioity inversion between containers - failure to offload cold memory to swap with proactive reclaim - breakdown of container health monitoring and userspace OOM killing I'm not exaggerating when I say we can't reliably operate our fleet without this patch. We've had to carry variants of it for two years now. It'd be great to get this fixed upstream. Thanks, Johannes