From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9150FC433F5 for ; Mon, 8 Nov 2021 09:25:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3293861288 for ; Mon, 8 Nov 2021 09:25:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3293861288 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C29F76B0074; Mon, 8 Nov 2021 04:25:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDA576B0075; Mon, 8 Nov 2021 04:25:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA2156B0078; Mon, 8 Nov 2021 04:25:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 9CC416B0074 for ; Mon, 8 Nov 2021 04:25:04 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4676E18339462 for ; Mon, 8 Nov 2021 09:25:04 +0000 (UTC) X-FDA: 78785228928.02.93CF6BB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id A138110000AE for ; Mon, 8 Nov 2021 09:25:03 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 42F621FD71; Mon, 8 Nov 2021 09:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1636363502; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SHWH2jFNs/MKAnHqbJ/fucH8U/PBAzjvELvO1YIaGf0=; b=ZE01o+8hjs7CEidEKgBp682WRKWL6X9+Afe7D9WUcRrwT4iNqj9E1Ia16gpzqu0NziE365 A2nUn74kwG2/E82w1QwFkuHRhRTo7h54NwVAe48rHCdTMmQJqgNcbTBBiHrHXSdhRrYYG/ FZV6iJh1/gHN62+gkpGdhYmXRpaopv0= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0E8EEA3B81; Mon, 8 Nov 2021 09:25:02 +0000 (UTC) Date: Mon, 8 Nov 2021 10:25:01 +0100 From: Michal Hocko To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, david@fromorbit.com, hch@infradead.org, idryomov@gmail.com, jlayton@kernel.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, neilb@suse.de, torvalds@linux-foundation.org, urezki@gmail.com Subject: Re: [patch 099/262] mm/vmalloc: be more explicit about supported gfp flags Message-ID: References: <20211105133408.cccbb98b71a77d5e8430aba1@linux-foundation.org> <20211105203950.AJ1Cnteeh%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211105203950.AJ1Cnteeh%akpm@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A138110000AE X-Stat-Signature: 3f18j7opezkt99moenz9xzm6omkwxd77 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ZE01o+8h; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-HE-Tag: 1636363503-348386 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 05-11-21 13:39:50, Andrew Morton wrote: > From: Michal Hocko > Subject: mm/vmalloc: be more explicit about supported gfp flags > > The core of the vmalloc allocator __vmalloc_area_node doesn't say anything > about gfp mask argument. Not all gfp flags are supported though. Be more > explicit about constraints. > > Link: https://lkml.kernel.org/r/20211020082545.4830-1-mhocko@kernel.org > Signed-off-by: Michal Hocko > Cc: Dave Chinner > Cc: Neil Brown > Cc: Christoph Hellwig > Cc: Uladzislau Rezki > Cc: Ilya Dryomov > Cc: Jeff Layton > Signed-off-by: Andrew Morton As already pointed out http://lkml.kernel.org/r/YXE+hcodJ7zxeYA7@dhcp22.suse.cz this patch cannot be applied without other patches from the same series. > --- > > mm/vmalloc.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > --- a/mm/vmalloc.c~mm-vmalloc-be-more-explicit-about-supported-gfp-flags > +++ a/mm/vmalloc.c > @@ -2983,8 +2983,16 @@ fail: > * @caller: caller's return address > * > * Allocate enough pages to cover @size from the page level > - * allocator with @gfp_mask flags. Map them into contiguous > - * kernel virtual space, using a pagetable protection of @prot. > + * allocator with @gfp_mask flags. Please note that the full set of gfp > + * flags are not supported. GFP_KERNEL would be a preferred allocation mode > + * but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not > + * supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka > + * GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka > + * __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported). > + * __GFP_NOWARN can be used to suppress error messages about failures. > + * > + * Map them into contiguous kernel virtual space, using a pagetable > + * protection of @prot. > * > * Return: the address of the area or %NULL on failure > */ > _ -- Michal Hocko SUSE Labs