From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF62C4332F for ; Thu, 4 Nov 2021 16:53:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8053961216 for ; Thu, 4 Nov 2021 16:53:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8053961216 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1809A6B006C; Thu, 4 Nov 2021 12:53:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12FC86B0072; Thu, 4 Nov 2021 12:53:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01EDA940007; Thu, 4 Nov 2021 12:53:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id E51336B006C for ; Thu, 4 Nov 2021 12:53:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9F36518311449 for ; Thu, 4 Nov 2021 16:53:58 +0000 (UTC) X-FDA: 78771844956.04.6E78464 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP id 34692F0000BA for ; Thu, 4 Nov 2021 16:53:58 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C7FD2611EE; Thu, 4 Nov 2021 16:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636044837; bh=Dhz9FmjLT35R+67iV11heDU4QCFq3O0PsHTKRHXxvYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bD635h5tby1U32S9rZycwUOGE2sFSOJdE30TJHVecwR3f0K/iqHJvG0Z1DHn2WPCR d1MSR9HdZgfMpS0Tib7e++/wJr+G4UqWrc52qUd3PsRyCDOuNssC81vMFoSxxWZI/v hfh/Jny08QeDasR0aeGoeUCuF2Ol0mTzeI2eRPF8= Date: Thu, 4 Nov 2021 17:53:54 +0100 From: Greg KH To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, osalvador@suse.de, peterx@redhat.com, akpm@linux-foundation.org, stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check Message-ID: References: <20211101194856.305642-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 34692F0000BA X-Stat-Signature: 9pgxyd5bbbswyktaq55bqq7ucxygi8gz Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=bD635h5t; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-HE-Tag: 1636044838-767284 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 03, 2021 at 10:46:24AM +0100, Greg KH wrote: > On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote: > > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. > > > > When handling THP hwpoison checked if the THP is in allocation or free > > stage since hwpoison may mistreat it as hugetlb page. After commit > > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > > handling") the problem has been fixed, so this check is no longer > > needed. Remove it. The side effect of the removal is hwpoison may > > report unsplit THP instead of unknown error for shmem THP. It seems not > > like a big deal. > > > > The following patch "mm: filemap: check if THP has hwpoisoned subpage > > for PMD page fault" depends on this, which fixes shmem THP with > > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > > backported to -stable as well. > > > > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com > > Signed-off-by: Yang Shi > > Suggested-by: Naoya Horiguchi > > Acked-by: Naoya Horiguchi > > Cc: Hugh Dickins > > Cc: Kirill A. Shutemov > > Cc: Matthew Wilcox > > Cc: Oscar Salvador > > Cc: Peter Xu > > Cc: > > Signed-off-by: Andrew Morton > > Signed-off-by: Linus Torvalds > > --- > > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch > > depends on this one. > > Both now queued up, thanks. This breaks the build, see: https://lore.kernel.org/r/acabc414-164b-cd65-6a1a-cf912d8621d7@roeck-us.net so I'm going to drop both of these now. Please fix this up and resend a tested series. thanks, greg k-h