From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Shi <shy828301@gmail.com>
Cc: naoya.horiguchi@nec.com, hughd@google.com,
kirill.shutemov@linux.intel.com, willy@infradead.org,
osalvador@suse.de, peterx@redhat.com, akpm@linux-foundation.org,
stable@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check
Date: Thu, 4 Nov 2021 17:53:54 +0100 [thread overview]
Message-ID: <YYQQIu6Xi/iEEb7f@kroah.com> (raw)
In-Reply-To: <YYJacGTst7dceD8K@kroah.com>
On Wed, Nov 03, 2021 at 10:46:24AM +0100, Greg KH wrote:
> On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote:
> > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream.
> >
> > When handling THP hwpoison checked if the THP is in allocation or free
> > stage since hwpoison may mistreat it as hugetlb page. After commit
> > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> > handling") the problem has been fixed, so this check is no longer
> > needed. Remove it. The side effect of the removal is hwpoison may
> > report unsplit THP instead of unknown error for shmem THP. It seems not
> > like a big deal.
> >
> > The following patch "mm: filemap: check if THP has hwpoisoned subpage
> > for PMD page fault" depends on this, which fixes shmem THP with
> > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be
> > backported to -stable as well.
> >
> > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com
> > Signed-off-by: Yang Shi <shy828301@gmail.com>
> > Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> > Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> > Cc: Hugh Dickins <hughd@google.com>
> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Cc: Matthew Wilcox <willy@infradead.org>
> > Cc: Oscar Salvador <osalvador@suse.de>
> > Cc: Peter Xu <peterx@redhat.com>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > ---
> > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch
> > depends on this one.
>
> Both now queued up, thanks.
This breaks the build, see:
https://lore.kernel.org/r/acabc414-164b-cd65-6a1a-cf912d8621d7@roeck-us.net
so I'm going to drop both of these now. Please fix this up and resend a
tested series.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-04 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 19:48 Yang Shi
2021-11-03 9:46 ` Greg KH
2021-11-04 16:53 ` Greg KH [this message]
2021-11-04 17:43 ` Yang Shi
2021-11-04 18:07 ` Yang Shi
2021-11-04 18:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYQQIu6Xi/iEEb7f@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox