From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CDBC433F5 for ; Wed, 3 Nov 2021 13:24:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5A6761058 for ; Wed, 3 Nov 2021 13:24:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5A6761058 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3FC4F6B006C; Wed, 3 Nov 2021 09:24:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ABF96B0071; Wed, 3 Nov 2021 09:24:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B556B0072; Wed, 3 Nov 2021 09:24:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 1BDEB6B006C for ; Wed, 3 Nov 2021 09:24:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A001418046C56 for ; Wed, 3 Nov 2021 13:24:28 +0000 (UTC) X-FDA: 78767688216.29.945B677 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id EF216F0003A3 for ; Wed, 3 Nov 2021 13:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=z83BEBMepikQKZaP7EwgKglGj7+Xl9d+0OspVk4dFzg=; b=L4/mKn8kutBEl0TkUQJ6klzqsR qLPAy5ZFYF3BO83gwwJmwULBp+Q9KJL7eUjjz9niSU/Kx2FoHaQQyz3wAv9aoOwRIC5MlhtOI53Wg Bml8n9+v0exM+gHGB6surId2PyAY+bjT7Urkd+4DSWGAxCHtN0qmFc8kZKmH5mBIyJm8LnUX8uv5M qkGgWMP8CxZtf3mAjlCqC4+XT2CADd17BtoHE5OP6og3XM0iKsRCRRwybK/G/RxoTOwY5M6R/i3oi /e6KirRaXVvvsJxSX6zm3lEi6xYqN2IGYM5POKKxd5LfgDMSq0S8uEFElxfvBIALagP4KkypLu889 CmGxnfIQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1miG7U-005DZJ-PP; Wed, 03 Nov 2021 13:16:32 +0000 Date: Wed, 3 Nov 2021 13:16:00 +0000 From: Matthew Wilcox To: David Howells Cc: Jeff Layton , Ilya Dryomov , Dominique Martinet , linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] folio: Add a function to get the host inode for a folio Message-ID: References: <163584174921.4023316.8927114426959755223.stgit@warthog.procyon.org.uk> <163584184628.4023316.9386282630968981869.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163584184628.4023316.9386282630968981869.stgit@warthog.procyon.org.uk> X-Rspamd-Queue-Id: EF216F0003A3 X-Stat-Signature: 87crdctz5a5uiwzutcbf3saxtpbtt9e4 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="L4/mKn8k"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-HE-Tag: 1635945867-531115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 02, 2021 at 08:30:46AM +0000, David Howells wrote: > Add a convenience function, folio_inode() that will get the host inode from > a folio's mapping. I'm not opposed, but it only saves two characters, so I'm not entirely sure it justifies its existance. On the other hand, folio_inode() is clear about what it does. > + * For folios which are in the page cache, return the inode that is hosting > + * this folio belongs to. This looks like an editing mistake. Either you meant 'return the inode that hosts this folio' or 'return the inode this folio belongs to' (and i prefer the second). With that grammo fixed, Reviewed-by: Matthew Wilcox (Oracle)