From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194D3C433FE for ; Wed, 3 Nov 2021 09:46:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1F656112D for ; Wed, 3 Nov 2021 09:46:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B1F656112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2CF786B006C; Wed, 3 Nov 2021 05:46:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27FE7940007; Wed, 3 Nov 2021 05:46:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16EAD6B0072; Wed, 3 Nov 2021 05:46:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 091A06B006C for ; Wed, 3 Nov 2021 05:46:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C375F8249980 for ; Wed, 3 Nov 2021 09:46:34 +0000 (UTC) X-FDA: 78767139108.13.3F2593C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id 11AAFE0016A1 for ; Wed, 3 Nov 2021 09:46:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D3FD6113B; Wed, 3 Nov 2021 09:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635932792; bh=JCi57Xe87vMD6it97QtxyVClRxGWin28JiPQM/PNxXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bneuEKaAdHECFDnx94bbIp260s+LI+jR0VcjtwrIrBlTxKQ3z3me+H9bNobVOJiIo 0VtywvsFq0zscmyMoWDeqVNAD9bxKXSg7Ag6ISx8FxNcMxtIKHXEQpi/iGneEtfn5a UAka8oAggOnnbugDBD2ZfshujS28F41Eu5D4hAbg= Date: Wed, 3 Nov 2021 10:46:24 +0100 From: Greg KH To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, osalvador@suse.de, peterx@redhat.com, akpm@linux-foundation.org, stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check Message-ID: References: <20211101194856.305642-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211101194856.305642-1-shy828301@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 11AAFE0016A1 X-Stat-Signature: ot83anp57xjemfep7p6gf5pjketneuyn Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=bneuEKaA; spf=pass (imf30.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1635932778-392023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote: > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream. > > When handling THP hwpoison checked if the THP is in allocation or free > stage since hwpoison may mistreat it as hugetlb page. After commit > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > handling") the problem has been fixed, so this check is no longer > needed. Remove it. The side effect of the removal is hwpoison may > report unsplit THP instead of unknown error for shmem THP. It seems not > like a big deal. > > The following patch "mm: filemap: check if THP has hwpoisoned subpage > for PMD page fault" depends on this, which fixes shmem THP with > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > backported to -stable as well. > > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com > Signed-off-by: Yang Shi > Suggested-by: Naoya Horiguchi > Acked-by: Naoya Horiguchi > Cc: Hugh Dickins > Cc: Kirill A. Shutemov > Cc: Matthew Wilcox > Cc: Oscar Salvador > Cc: Peter Xu > Cc: > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > --- > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch > depends on this one. Both now queued up, thanks. greg k-h