From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1AEC433F5 for ; Tue, 2 Nov 2021 07:56:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5351A60F70 for ; Tue, 2 Nov 2021 07:56:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5351A60F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E341A6B00C5; Tue, 2 Nov 2021 03:56:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE36B6B00C7; Tue, 2 Nov 2021 03:56:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C84FF94000A; Tue, 2 Nov 2021 03:56:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id BA4656B00C5 for ; Tue, 2 Nov 2021 03:56:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6B26E1F854 for ; Tue, 2 Nov 2021 07:56:20 +0000 (UTC) X-FDA: 78763232520.14.2F3C720 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 1DD356001981 for ; Tue, 2 Nov 2021 07:56:09 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B46FE21956; Tue, 2 Nov 2021 07:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1635839778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6ap4olzBTfLejakCPItyAX9e8bDmpSosfrrPGCanr3k=; b=WwJzLSQXjGdAyznGGV6SpWmdhW49bQlRnvPytZ6fgxedhPeRJVVTgMy0Ih0O5QwjOYpS6a 96PQR55FMHbwdMZIMobPll5efDcxRY2ZviZSkiefrXc10IHo417/75YCqs3hplKbT1wpnR lqnAN+Chyaj0oXodeKoyvl4MpccGfbE= Received: from suse.cz (unknown [10.100.224.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A7312A3B88; Tue, 2 Nov 2021 07:56:17 +0000 (UTC) Date: Tue, 2 Nov 2021 08:56:14 +0100 From: Petr Mladek To: Yafang Shao Cc: Steven Rostedt , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 Message-ID: References: <20211101060419.4682-1-laoar.shao@gmail.com> <20211101211845.20ff5b2e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1DD356001981 X-Stat-Signature: 8hbpyos13uuame5jnc4gff19u435ywy8 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WwJzLSQX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf10.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com X-HE-Tag: 1635839769-255056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 2021-11-02 09:26:35, Yafang Shao wrote: > On Tue, Nov 2, 2021 at 9:18 AM Steven Rostedt wrote: > > On Tue, 2 Nov 2021 09:09:50 +0800 > > Yafang Shao wrote: > > > Now we only care about kthread, so we can put the pointer into a > > > kthread specific struct. > > > For example in the struct kthread, or in kthread->data (which may > > > conflict with workqueue). > > > > No, add a new field to the structure. "full_name" or something like that. > > I'm guessing it should be NULL if the name fits in TASK_COMM_LEN and > > allocated if the name had to be truncated. > > > > Do not overload data with this. That will just make things confusing. > > There's not that many kthreads, where an addition of an 8 byte pointer is > > going to cause issues. > > Sure, I will add a new field named "full_name", which only be > allocated if the kthread's comm is truncated. The plan looks good to me. One more thing. It should obsolete the workqueue-specific solution. It would be great to clean up the workqueue code as the next step. Best Regards, Petr