From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC66C433F5 for ; Fri, 12 Nov 2021 07:44:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DBC060F26 for ; Fri, 12 Nov 2021 07:44:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6DBC060F26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 09A7B6B0074; Fri, 12 Nov 2021 02:44:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 022676B0078; Fri, 12 Nov 2021 02:44:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2CB46B007B; Fri, 12 Nov 2021 02:44:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id CD36A6B0074 for ; Fri, 12 Nov 2021 02:44:35 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 88ADA1848893C for ; Fri, 12 Nov 2021 07:44:35 +0000 (UTC) X-FDA: 78799490910.31.3D22E71 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 5C1DEE002109 for ; Fri, 12 Nov 2021 07:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636703005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2+bbLPuvp6j+cegdNKlEPJqnoq6OmsKUa3Sntf90VmI=; b=gbA/Ns77ZiSf75JXhS+rFC3ZTasLE7WIG1evsZr7njY6xETxEHtyYvqXl7hjLy8Srya3rZ MAFtBGJlHk+ZDGT3P9dnEE6KsDG/K8pydIh9iKMLbOa2oHlI8Tutmxfd++ZSnIwgLH4Rsm BqIh8nMfJgIS8j1OClfAOLoqRUdnRRM= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-j-ZuLo36N5GyTShC8m1PEA-1; Fri, 12 Nov 2021 02:43:24 -0500 X-MC-Unique: j-ZuLo36N5GyTShC8m1PEA-1 Received: by mail-pf1-f197.google.com with SMTP id c140-20020a624e92000000b0044d3de98438so5278687pfb.14 for ; Thu, 11 Nov 2021 23:43:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2+bbLPuvp6j+cegdNKlEPJqnoq6OmsKUa3Sntf90VmI=; b=sUBBL6l56zgwXK+dIYayrGlTr6IVunyFbScdbSX7c2GUkQ9aFqlONDP4l1eQ+Tw4K8 9wqWfsrDU3g8NNdBLHMlWbtjq2yIpg4KfqFOcGZ0Et/S7RpGOcnUNtesaSW2EWwA5HmF 6Tm4BrmTVwcQNsrOiM96p9yewpaQt1O4PEgwuz5/At4ttjpS5rdDktGgmdwWcgURn68a RMbKYe1Oie38ipWlSNudI34gXFa6Ao1YkplHhNjZa1UELXdmMg4UU0MJfHq3IhV18fwP CUC8skxdtQftFZp1iV18IF0IDs3FvYSQo2Voqxdq0EvX/QxMNBWCeACKF1RyCanU415/ BWmg== X-Gm-Message-State: AOAM530wZ0gTtW0ioyWQmyq6/Dj5TnHZbdKIideHwPUIUhObol8SXPz4 eX+cRWXoFgUJn99EhiEn4VVls0HJa16hUtPVcl2dQ8RFt4CwZpbSP+60zlkXuSqVVeS1bRJVqIs 1ZaiEHFe9/ko= X-Received: by 2002:a62:e907:0:b0:4a0:3a71:9712 with SMTP id j7-20020a62e907000000b004a03a719712mr11992018pfh.73.1636703003633; Thu, 11 Nov 2021 23:43:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW65zsGOp0tOg78dGWcQxPMcJVbcn+Q5ElOLrsIyJjMaVrE4YLHP5pKzdyX2p+4jQg0KZ6Bg== X-Received: by 2002:a62:e907:0:b0:4a0:3a71:9712 with SMTP id j7-20020a62e907000000b004a03a719712mr11991987pfh.73.1636703003370; Thu, 11 Nov 2021 23:43:23 -0800 (PST) Received: from xz-m1.local ([94.177.118.141]) by smtp.gmail.com with ESMTPSA id h12sm5667373pfv.117.2021.11.11.23.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 23:43:22 -0800 (PST) Date: Fri, 12 Nov 2021 15:43:16 +0800 From: Peter Xu To: Mina Almasry Cc: David Hildenbrand , Matthew Wilcox , "Paul E . McKenney" , Yu Zhao , Jonathan Corbet , Andrew Morton , Ivan Teterevkov , Florian Schmidt , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap Message-ID: References: <20211107235754.1395488-1-almasrymina@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gbA/Ns77"; spf=none (imf30.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5C1DEE002109 X-Stat-Signature: trnnu8ih3m7itch136xekc8bpz1ircj9 X-HE-Tag: 1636702984-534470 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 10, 2021 at 09:50:13AM -0800, Mina Almasry wrote: > On Tue, Nov 9, 2021 at 11:03 PM Peter Xu wrote: > > > > The ending "_MAPPING" seems redundant to me, how about just call it "PM_THP" or > > "PM_HUGE" (as THP also means HUGE already)? > > > > So I want to make it clear that the flag is set only when the page is > PMD mappend and is a THP (not hugetlbfs or some other PMD device > mapping). PM_THP would imply the flag is set only if the underlying > page is THP without regard to whether it's actually PMD mapped or not. I see, that's fine. However as I mentioned I still think HUGE and THP dup with each other. Meanwhile, "MAPPING" does not sound like a boolean status on whether it's thp mapped.. If you still prefer this approach, how about PM_THP_MAPPED? -- Peter Xu