From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4DCC433FE for ; Wed, 27 Oct 2021 21:40:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE0BE610CB for ; Wed, 27 Oct 2021 21:40:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE0BE610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EAB746B0071; Wed, 27 Oct 2021 17:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5ADF6B0072; Wed, 27 Oct 2021 17:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4A14940007; Wed, 27 Oct 2021 17:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id A7F816B0071 for ; Wed, 27 Oct 2021 17:40:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 35BE418029D8E for ; Wed, 27 Oct 2021 21:40:07 +0000 (UTC) X-FDA: 78743535654.24.870BC12 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 4D9445000307 for ; Wed, 27 Oct 2021 21:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mj+64iVUFU770oqi2STnF0e0M2cIBSTKCrEACVMYR0Q=; b=danKNLwLstO6xW/jQipEHusI9v K5jANdbG4bqgWj5/hnetwQn4FPcjzGYhpRM5BuflIgJOw5iBXfKF3c+KUeUk6IEREAS+J2+hh0P/6 PP5JV16GvTHfhbLqa9sFRthQzdCVxZaGEa6/eR/sC/h/SdNaVuIo0zrf87wW7rcauxTjnm895u6bW EbakBCT9ZP8MadkxT96NXYvrD1UhVC5hR1vUTu11Z+5ywyV2g85xM8cgK6WV2NLWLgZibxn+HO9nJ 4A6+x9b8RwgIW2CJfLhmlrtUzT/ggfmGp+SzqUPDULYekHsQ8fRB/Yjo4tDJOw6+8UE6TOOlR4MM5 DfA3459Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfqbV-000Kzm-Eo; Wed, 27 Oct 2021 21:37:24 +0000 Date: Wed, 27 Oct 2021 22:37:01 +0100 From: Matthew Wilcox To: Yang Shi Cc: Hugh Dickins , Hao Sun , "Kirill A. Shutemov" , Song Liu , Andrea Righi , Andrew Morton , Linux MM , Linux Kernel Mailing List , stable Subject: Re: [PATCH] mm: khugepaged: skip huge page collapse for special files Message-ID: References: <20211027195221.3825-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ty71ao9hscj7muxkfo5t3nmwkks61jrz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4D9445000307 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=danKNLwL; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1635370800-818463 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 27, 2021 at 02:32:02PM -0700, Yang Shi wrote: > > This doesn't make sense to me. if vma->vm_file, we already returned, > > so this is dead code. > > Yes, Song mentioned the same thing. Fixed by an incremental patch. I saw that after I sent this. My email sometimes arrives slowly.