From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <shy828301@gmail.com>
Cc: Hugh Dickins <hughd@google.com>, Hao Sun <sunhao.th@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Andrea Righi <andrea.righi@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] mm: khugepaged: skip huge page collapse for special files
Date: Wed, 27 Oct 2021 22:37:01 +0100 [thread overview]
Message-ID: <YXnGfaw5fh8aBNnG@casper.infradead.org> (raw)
In-Reply-To: <CAHbLzkrV1SuqZ8750yD6ZDM9D9uc8svrJ_gARrESq0kMspg+uw@mail.gmail.com>
On Wed, Oct 27, 2021 at 02:32:02PM -0700, Yang Shi wrote:
> > This doesn't make sense to me. if vma->vm_file, we already returned,
> > so this is dead code.
>
> Yes, Song mentioned the same thing. Fixed by an incremental patch.
I saw that after I sent this. My email sometimes arrives slowly.
prev parent reply other threads:[~2021-10-27 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 19:52 Yang Shi
2021-10-27 20:34 ` Song Liu
2021-10-27 20:44 ` Yang Shi
2021-10-27 20:53 ` Andrew Morton
2021-10-27 21:57 ` Yang Shi
2021-10-27 20:50 ` Matthew Wilcox
2021-10-27 21:32 ` Yang Shi
2021-10-27 21:37 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXnGfaw5fh8aBNnG@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andrea.righi@canonical.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=sunhao.th@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox