From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0775C433EF for ; Tue, 26 Oct 2021 23:50:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4CF7A600CC for ; Tue, 26 Oct 2021 23:50:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CF7A600CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E0404940008; Tue, 26 Oct 2021 19:50:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB4E6940007; Tue, 26 Oct 2021 19:50:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA27F940008; Tue, 26 Oct 2021 19:50:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id B992A940007 for ; Tue, 26 Oct 2021 19:50:38 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6C09E18241943 for ; Tue, 26 Oct 2021 23:50:38 +0000 (UTC) X-FDA: 78740235756.37.626D1DE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 012DBB0000BA for ; Tue, 26 Oct 2021 23:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0lW0nywobAhfvx+Rkg2aIOHXuEPbjaEywp8tzeijQnY=; b=EolnIW9mx3J0RUHxcvClKo9Fbg m4hG8it/zH474ircewrDmA988rctW+DLv7MGG54ruE0QeQ4tY/uoyP+i0Ao8VsSDsb0qvocAb2hqg TqPd40v9I1wA9lBd2O+slDvBKDUfwMkAm/bDGAUq5/qtHZFLL1GzIHvBcPEiiTqt/ktEx28YDWa2m 2PbXPDqQ0qfYn9MZYGOtVmJOtJZgu37WlyTWORfE39s9KGYrXEwoK0yimgpSQBZ90oEdsYrQ1VKkv y1F3EFhJbs5h9Hwer4whVM9FysA9lNu5Q6Mts6D0D/1rRo5SP4hGODwK7Q6X0kOeScU4xgdVrlV8A EEJUaOFQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfWCT-00HGNC-4w; Tue, 26 Oct 2021 23:49:56 +0000 Date: Wed, 27 Oct 2021 00:49:49 +0100 From: Matthew Wilcox To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Andrew Morton , Pasha Tatashin Subject: Re: [PATCH] hugetlb: remove unnecessary set_page_count in prep_compound_gigantic_page Message-ID: References: <20211026220635.35187-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211026220635.35187-1-mike.kravetz@oracle.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 012DBB0000BA X-Stat-Signature: an7a7gj3fscex46hsb36rbrh6ofphhbc Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EolnIW9m; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1635292237-814657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 26, 2021 at 03:06:35PM -0700, Mike Kravetz wrote: > In commit 7118fc2906e29 ("hugetlb: address ref count racing in > prep_compound_gigantic_page"), page_ref_freeze is used to atomically > zero the ref count of tail pages iff they are 1. The unconditional > call to set_page_count(0) was left in the code. This call is after > page_ref_freeze so it is really a noop. > > Remove redundant and unnecessary set_page_count call. > > Fixes: 7118fc2906e29 ("hugetlb: address ref count racing in prep_compound_gigantic_page") > Suggested-by: Pasha Tatashin > Signed-off-by: Mike Kravetz Reviewed-by: Matthew Wilcox (Oracle)