From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66313C433FE for ; Mon, 25 Oct 2021 21:49:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0A0F60524 for ; Mon, 25 Oct 2021 21:49:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0A0F60524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7999780007; Mon, 25 Oct 2021 17:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 748C8940008; Mon, 25 Oct 2021 17:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 669D0940007; Mon, 25 Oct 2021 17:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 56416940007 for ; Mon, 25 Oct 2021 17:49:32 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1457732086 for ; Mon, 25 Oct 2021 21:49:32 +0000 (UTC) X-FDA: 78736301784.38.9F7CAE1 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf22.hostedemail.com (Postfix) with ESMTP id B0D071904 for ; Mon, 25 Oct 2021 21:49:31 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id a26so1413274pfr.11 for ; Mon, 25 Oct 2021 14:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=baPV4wjWZkGX1/OiILxvL9eAGAhGEPzvMBmxxzMUQ18=; b=QXLi5LxfSEiZQavsYMecHFC1Ryzi+j4JIobg4vPw2H51u+3Qpgk/qgk/ux/t1ReruM KiQESzV0bS9HJD+QdTRhClZDtSVjlkkab5WA6j2w3dZRfoFbPsPL0gBa/k/89DiD2kgv ttzh3g7mvljlgu6xKH6VRjJ0an+TfrtWlQDe32vWWSqYRY5m5AyHBToW+6c6WMkFtCDb iNUj6XPu9CN333mq03+/gZIkzsqEJPtKnvWpKB6z90AQW91h8WhfhO6x7hjbK00/sd+o RDj99muUDZ3+JeYLZUVzdbnIejOlLaajjMCi+a6XlYTnljUNCUtzUxpa89nTOiISnYCU eI+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=baPV4wjWZkGX1/OiILxvL9eAGAhGEPzvMBmxxzMUQ18=; b=UWm0SHmvycCVOCRVv2TKK66PPj7IuWDFXwY6rUkXlmyqZSspmeOizGDKsOxbxSgdNH yQC+hmmtoaATKMhd29lz5/AX3V6IyvNxYRziXOb+O5DGdFNTQ76OUKKVDMcjH+s/GnrF JTB9JFwOfHijNVdj6odW/wy0X8UY1a6tmIQWeJrIRE2MuBtvoDv09KGojfO7xlur9jjZ TQPYh7tVeT2gzGbCM5ZcrsPpcxJJJBGJqvpVAKL4ykNuZQuW6vt7e7mshP8d9SPvgZgv lZpRU/SAk09x5JkifFUzJpMzL2rQHFtj8faV/yIUma8QJodyxcJeEXKEkRoKsAxy7wsK 422Q== X-Gm-Message-State: AOAM533TNDkBMcZhgJTfNV16J6Zc8SzKpo7vTrM/IYfnBmmPgDtbKI9S BYTQ3TfBv9hkAnNEse2n6qw= X-Google-Smtp-Source: ABdhPJw1xycS/uWoVr3qeOLq5p9ffEYMa8CRtNzgPJKpeoMGS3IBSCUUq5cibp2J+FKWyHMhlzcgRQ== X-Received: by 2002:a62:9282:0:b0:47b:d0e9:a3c4 with SMTP id o124-20020a629282000000b0047bd0e9a3c4mr18809568pfd.12.1635198570571; Mon, 25 Oct 2021 14:49:30 -0700 (PDT) Received: from nuc10 (d50-92-229-34.bchsia.telus.net. [50.92.229.34]) by smtp.gmail.com with ESMTPSA id p23sm9676409pfw.61.2021.10.25.14.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 14:49:30 -0700 (PDT) Date: Mon, 25 Oct 2021 14:49:28 -0700 From: Rustam Kovhaev To: Vlastimil Babka Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, corbet@lwn.net, djwong@kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, dvyukov@google.com Subject: Re: [PATCH v2] slob: add size header to all allocations Message-ID: References: <1dfb7a79-3e66-a9fe-ee7c-1277d7ff5950@suse.cz> <20211023064114.708532-1-rkovhaev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B0D071904 X-Stat-Signature: rkjd3kkuy83oifdd48j5rbhwpk6prpec Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QXLi5Lxf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of rkovhaev@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=rkovhaev@gmail.com X-HE-Tag: 1635198571-514930 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 25, 2021 at 11:36:53AM +0200, Vlastimil Babka wrote: > On 10/23/21 08:41, Rustam Kovhaev wrote: > > Let's prepend both kmalloc() and kmem_cache_alloc() allocations with the > > size header. > > It simplifies the slab API and guarantees that both kmem_cache_alloc() > > and kmalloc() memory could be freed by kfree(). > > > > meminfo right after the system boot, without the patch: > > Slab: 35456 kB > > > > the same, with the patch: > > Slab: 36160 kB > > > > Link: https://lore.kernel.org/lkml/20210929212347.1139666-1-rkovhaev@gmail.com > > Signed-off-by: Rustam Kovhaev > > Seems overal correct to me, thanks! I'll just suggest some improvements: Thank you, I'll send a v3.