From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA04CC433EF for ; Mon, 25 Oct 2021 11:00:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 479B660EDF for ; Mon, 25 Oct 2021 11:00:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 479B660EDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D85E76B006C; Mon, 25 Oct 2021 07:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0E426B0072; Mon, 25 Oct 2021 07:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAF33940007; Mon, 25 Oct 2021 07:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id A8A326B006C for ; Mon, 25 Oct 2021 07:00:03 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 592A78249980 for ; Mon, 25 Oct 2021 11:00:03 +0000 (UTC) X-FDA: 78734665086.34.88B470C Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf28.hostedemail.com (Postfix) with ESMTP id 05694900009A for ; Mon, 25 Oct 2021 11:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=acPLA71S1ep7pYBvutH8rAYXBSbDlehTnu3UD961M04=; b=FIjBlj52Y8W6YmMnXMkuPpo4u3 aWPYKAZG3rmv1OW4UfS953EDP3UVSfXwLZJetgX2iGwm4pTvo0ftDFJE19juoV/GZgoosmTYQqYu+ M1I/MCKsgq3f3rj1hVb9VZ/of6kP3lNl6CxEsk8FXjIXpLo1tk+hssqJ0jdCfTBgxWsY5b6fulEHm n7wPW9/5TaDte5l5qbBbJZMaqztRueLYDn2E7kJqLtu0bqFmC9ZmRZm0yoUG3z4QbvU42JHgHH7bp jfAF7WdEkEotfpXKAlbtWcF9Nrx/82oGtZ+h26XqPzT7yBJYjN5nt/OCscg8nM4rpGNUqnkUtXTF5 wDSKMwQA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mexht-00C8Ba-PZ; Mon, 25 Oct 2021 10:59:57 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A6849300230; Mon, 25 Oct 2021 12:59:56 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8F67D20C6C14F; Mon, 25 Oct 2021 12:59:56 +0200 (CEST) Date: Mon, 25 Oct 2021 12:59:56 +0200 From: Peter Zijlstra To: Nadav Amit Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nadav Amit , Andrea Arcangeli , Andrew Cooper , Andrew Morton , Andy Lutomirski , Dave Hansen , Peter Xu , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin , x86@kernel.org Subject: Re: [PATCH v2 3/5] x86/mm: check exec permissions on fault Message-ID: References: <20211021122112.592634-1-namit@vmware.com> <20211021122112.592634-4-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021122112.592634-4-namit@vmware.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 05694900009A X-Stat-Signature: do4rukcibx7onefar7grbj7p6ib5ku8j Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=FIjBlj52; dmarc=none; spf=none (imf28.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org X-HE-Tag: 1635159602-172978 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 21, 2021 at 05:21:10AM -0700, Nadav Amit wrote: > From: Nadav Amit > Add a check to prevent access_error() from returning mistakenly that > page-faults due to instruction fetch are not allowed. Intel SDM does not > indicate whether "instruction fetch" and "write" in the hardware error > code are mutual exclusive, so check both before returning whether the > access is allowed. Dave, can we get that clarified? It seems a bit naf and leads to confusing code IMO. Other than that, the change looks ok to me. > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index b2eefdefc108..e776130473ce 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -1100,10 +1100,17 @@ access_error(unsigned long error_code, struct vm_area_struct *vma) > (error_code & X86_PF_INSTR), foreign)) > return 1; > > - if (error_code & X86_PF_WRITE) { > + if (error_code & (X86_PF_WRITE | X86_PF_INSTR)) { > /* write, present and write, not present: */ > - if (unlikely(!(vma->vm_flags & VM_WRITE))) > + if ((error_code & X86_PF_WRITE) && > + unlikely(!(vma->vm_flags & VM_WRITE))) > return 1; > + > + /* exec, present and exec, not present: */ > + if ((error_code & X86_PF_INSTR) && > + unlikely(!(vma->vm_flags & VM_EXEC))) > + return 1; > + > return 0; > }