[PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c

[PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c

[Kushal Kothari]

The default value of static variable is zero and bool is false so
not need to set it here.
This patch fixes this ERROR in memblock.c

Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
---
 mm/memblock.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 5c3503c98b2f..57b9153b2278 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -16,7 +16,7 @@
 #include <linux/kmemleak.h>
 #include <linux/seq_file.h>
 #include <linux/memblock.h>
-
+#include<stdbool.h>
 #include <asm/sections.h>
 #include <linux/io.h>
 
@@ -152,10 +152,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory;
 	} while (0)
 
 static int memblock_debug __initdata_memblock;
-static bool system_has_some_mirror __initdata_memblock = false;
+static bool system_has_some_mirror __initdata_memblock;
 static int memblock_can_resize __initdata_memblock;
-static int memblock_memory_in_slab __initdata_memblock = 0;
-static int memblock_reserved_in_slab __initdata_memblock = 0;
+static int memblock_memory_in_slab __initdata_memblock;
+static int memblock_reserved_in_slab __initdata_memblock;
 
 static enum memblock_flags __init_memblock choose_memblock_flags(void)
 {
-- 
2.25.1

Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c

[Matthew Wilcox]

On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote:
> The default value of static variable is zero and bool is false so
> not need to set it here.
> This patch fixes this ERROR in memblock.c

Why does the subject line say "staging"?  What tool reports this as an
"ERROR"?

> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> ---
>  mm/memblock.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 5c3503c98b2f..57b9153b2278 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -16,7 +16,7 @@
>  #include <linux/kmemleak.h>
>  #include <linux/seq_file.h>
>  #include <linux/memblock.h>
> -
> +#include<stdbool.h>

Why are you including stdbool here?  Why do you not justify it in the
changelog?

Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c

[kushal kothari]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

>Why does the subject line say "staging"?  What tool reports this as an
>"ERROR"?

Sorry. I made a mistake there while writing the subject line and adding
<stdbool.h>.
I am fixing it in v2.
I ran the checkpatch.pl script which reported this error.


On Mon, Nov 1, 2021 at 8:10 PM Matthew Wilcox <willy@infradead.org> wrote:

> On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote:
> > The default value of static variable is zero and bool is false so
> > not need to set it here.
> > This patch fixes this ERROR in memblock.c
>
> Why does the subject line say "staging"?  What tool reports this as an
> "ERROR"?
>
> > Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> > ---
> >  mm/memblock.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index 5c3503c98b2f..57b9153b2278 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -16,7 +16,7 @@
> >  #include <linux/kmemleak.h>
> >  #include <linux/seq_file.h>
> >  #include <linux/memblock.h>
> > -
> > +#include<stdbool.h>
>
> Why are you including stdbool here?  Why do you not justify it in the
> changelog?
>
>

[-- Attachment #2: Type: text/html, Size: 1926 bytes --]