From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195CCC433F5 for ; Mon, 1 Nov 2021 14:41:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA54461078 for ; Mon, 1 Nov 2021 14:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA54461078 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5C73194001A; Mon, 1 Nov 2021 10:41:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5770694000F; Mon, 1 Nov 2021 10:41:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4664F94001A; Mon, 1 Nov 2021 10:41:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 341CA94000F for ; Mon, 1 Nov 2021 10:41:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EA13E82499A8 for ; Mon, 1 Nov 2021 14:41:30 +0000 (UTC) X-FDA: 78760624740.23.836FBFC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id A1A141044813 for ; Mon, 1 Nov 2021 14:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uUUawBfqof3MazZFelNAf+4jZ9WvINAWpNw9e92RjoE=; b=FeuCOGrVu8nkciBsbui2puCSHA 89IKHilpx/fkmRdLIJlqJlNBsNS94j0gMomVdAwptCcpmJYsXW2qkbbnXZKxNDYadEqw+ZF+9/PiH O2RqeuRgQZYtn9w4a29lheXPcM5Q1zDXN8K16K+WMJIYkeU2ONWloXtJxY2A22TB4rWp5CG4avYsB kDN4itCsCjY9Dl1i+vjJW1WaiHasFB20cVwZckoRPUevBi147E500qYKVhpEL6/YlYDPIzX1ff92O ffmZPuSF2m78XHzf0TKJZA3yM05jeqbjxw3qr9O9iQzy9u1qKRIPF3SzcOd4S7Q2rmLUSg/573sVN GOrO6hwQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhYSq-003pMp-Ex; Mon, 01 Nov 2021 14:39:50 +0000 Date: Mon, 1 Nov 2021 14:39:08 +0000 From: Matthew Wilcox To: Kushal Kothari Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mike.rapoport@gmail.com, kushalkothari2850@gmail.com Subject: Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c Message-ID: References: <20211101101719.22538-1-kushalkothari285@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211101101719.22538-1-kushalkothari285@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A1A141044813 X-Stat-Signature: wnzdkrx7ic3im6oxwa9p4btr8748mwyw Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FeuCOGrV; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1635777682-426723 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote: > The default value of static variable is zero and bool is false so > not need to set it here. > This patch fixes this ERROR in memblock.c Why does the subject line say "staging"? What tool reports this as an "ERROR"? > Signed-off-by: Kushal Kothari > --- > mm/memblock.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 5c3503c98b2f..57b9153b2278 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -16,7 +16,7 @@ > #include > #include > #include > - > +#include Why are you including stdbool here? Why do you not justify it in the changelog?