From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F45C4332F for ; Fri, 15 Oct 2021 06:36:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77A3E61184 for ; Fri, 15 Oct 2021 06:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 77A3E61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 134DF6B006C; Fri, 15 Oct 2021 02:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E4A96B0071; Fri, 15 Oct 2021 02:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3C5A900002; Fri, 15 Oct 2021 02:36:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id E561A6B006C for ; Fri, 15 Oct 2021 02:36:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 67A7A31E55 for ; Fri, 15 Oct 2021 06:36:43 +0000 (UTC) X-FDA: 78697713486.06.7E281D6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 10AE8104190F for ; Fri, 15 Oct 2021 06:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jjb73SnOF4EFSmxfE0GW++wiA9PYNWRHRopAu7TvRYQ=; b=OT8rv34auPM5wdh4ZHemPKgNAh zHfqzy/4zRn2M4ITRnGp7Qsj3/M6fiIiclv8TEMv9COQdMvAKGd7TBGOw48avBLRVzJ/K5rbklwpI SYJaYDqCqv792TTOlbHDLaDr8VfldPohu46sTPnXwl+hBoCcy5ApjtuYoZAu0X+xBsBYboGGP5HRg /zou75h9G0NmPWKG/R1dxVu0W0r0O3BKgMhMjUKHZsAU7IpV6xKgsBV8PLHeNxC/py3I3G6zHgW0L HVVV+bdU5HYLM2W0BsFEdCApY8fw9RQpD8jn9w+mVPzwXmTg4MA8QP72g4tKVnRo55d8Si7dZWFOw F8j2qBjw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbGpb-005Yii-Sc; Fri, 15 Oct 2021 06:36:39 +0000 Date: Thu, 14 Oct 2021 23:36:39 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v7 4/8] pagemap,pmem: Introduce ->memory_failure() Message-ID: References: <20210924130959.2695749-1-ruansy.fnst@fujitsu.com> <20210924130959.2695749-5-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924130959.2695749-5-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 4ygqqru6usrzuj844w4dg99r3zrmifks Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OT8rv34a; spf=none (imf13.hostedemail.com: domain of BATV+717e4f5ff9d7c10515bf+6627+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+717e4f5ff9d7c10515bf+6627+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 10AE8104190F X-HE-Tag: 1634279801-458232 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Except for the error code inversion noticed by Darrick this looks fine to me: Reviewed-by: Christoph Hellwig