From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62246C4332F for ; Fri, 15 Oct 2021 06:33:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD6D961181 for ; Fri, 15 Oct 2021 06:33:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD6D961181 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5F32F900002; Fri, 15 Oct 2021 02:33:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2F26B0071; Fri, 15 Oct 2021 02:33:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49214900002; Fri, 15 Oct 2021 02:33:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 3A04E6B006C for ; Fri, 15 Oct 2021 02:33:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D9683180374CC for ; Fri, 15 Oct 2021 06:33:26 +0000 (UTC) X-FDA: 78697705212.15.5D05FED Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 8101CF00038D for ; Fri, 15 Oct 2021 06:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4ibEI1mmKq4vxjW0ktDbC03rpOftLIInrNed7E6F6lw=; b=PD18RHTKLYmxrJL3JNrRViKr/T v3oL7kaWHzpcXQfxYCP9JEFl+hit6oTueUu4j/03KIdsY++jtpDzji9wuJGVithaJJgjIvo9Mc88W J3A10QBCXUM0cdx9ZCRB0ttdwY/qb6WIMxjvWIrMV/6mVH8aKk1p+oHcHpJf7ZHpCtOY2hiRZidn0 fLxIjLufeU6/Qli2KoDOD1gTuF2Svj2TeSyntzVRJ2XOcLeETc2C4Ix+vEDuH2YR4g15bPog4CgF/ VTrdaeJfzIy1Wy1af3Gx4BWxGuCBe5XAdjGThbDtxYW+stQCDEDqj6WoNups26Yjg418hcsAsh9UU Mhsc8+vA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbGmQ-005Xpw-68; Fri, 15 Oct 2021 06:33:22 +0000 Date: Thu, 14 Oct 2021 23:33:22 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v7 3/8] mm: factor helpers for memory_failure_dev_pagemap Message-ID: References: <20210924130959.2695749-1-ruansy.fnst@fujitsu.com> <20210924130959.2695749-4-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924130959.2695749-4-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: aoh7gxpkcp7r78dthxi5j8hhjzb51q5r Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PD18RHTK; spf=none (imf17.hostedemail.com: domain of BATV+717e4f5ff9d7c10515bf+6627+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+717e4f5ff9d7c10515bf+6627+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8101CF00038D X-HE-Tag: 1634279606-246297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 24, 2021 at 09:09:54PM +0800, Shiyang Ruan wrote: > memory_failure_dev_pagemap code is a bit complex before introduce RMAP > feature for fsdax. So it is needed to factor some helper functions to > simplify these code. > > Signed-off-by: Shiyang Ruan > --- > mm/memory-failure.c | 140 ++++++++++++++++++++++++-------------------- > 1 file changed, 76 insertions(+), 64 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 54879c339024..8ff9b52823c0 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1430,6 +1430,79 @@ static int try_to_split_thp_page(struct page *page, const char *msg) > return 0; > } > > +static void unmap_and_kill(struct list_head *to_kill, unsigned long pfn, > + struct address_space *mapping, pgoff_t index, int flags) > +{ > + struct to_kill *tk; > + unsigned long size = 0; > + > + list_for_each_entry(tk, to_kill, nd) > + if (tk->size_shift) > + size = max(size, 1UL << tk->size_shift); > + if (size) { Nit: an empty line here would be nice for readability. > + if (pgmap->type == MEMORY_DEVICE_PRIVATE) { > + /* > + * TODO: Handle HMM pages which may need coordination > + * with device-side memory. > + */ > + return -EBUSY; We've got rid of the HMM terminology for device private memory, so I'd reword this update the comment to follow that while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig